Rows jump around during drag-and-drop when there are hidden columns

[helen]

Noted on the WordPress.org forums as a Yoast SEO conflict, but it appears to be an issue of any hidden columns. I'm guessing something in the drag-and-drop calculates the space needed for those hidden columns and we need to account for that somewhere.

More .org forum posts:

• https://wordpress.org/support/topic/row-height-on-drag-width/
• https://wordpress.org/support/topic/breaks-when-any-screen-option-in-unchecked/

Screencast

[smerriman]

I already reported this, along with the fix 2 and a half years ago. Last time the plugin was updated I contacted Jake via Slack and he said he'd look into it. Still hasn't been included.

https://wordpress.org/support/topic/breaks-when-any-screen-option-in-unchecked/

[helen]

@smerriman Yup, I went through more forum posts after I first opened this issue and already included a link to yours in the issue! If you’re up for a pull request that’d be great, otherwise I’ll work this into a maintenance cycle now that it’s less of a one-person show :)

[helen]

Looks like there was a neglected PR from @benhuson over at jakemgold/simple-page-ordering#7 - I've asked if he's up for bringing that over to the new file structure and opening a PR on this repo. I'll do a deeper review and follow up within the week - at the very least, I can use the co-authors functionality to get him credit.

[benhuson]

Hi Helen,

Looks like I couldn’t follow up your comment in the old repo as it has now been archived.

I may be able to put aside time tomorrow to check my old PR and see how it applies a PR to the latest repo.

Thanks

Ben

[benhuson]

@helen I have submitted a fresh PR against this repo. Fix works for me. #15

I've only submitted changes for the src JS file and tested in script debug mode. If all OK, the changes will still need to be applied to the .min.js file.

[adamsilverstein]

Fixed in #15