-
Notifications
You must be signed in to change notification settings - Fork 916
Add configurable TUI themes #437
Copy link
Copy link
Open
Labels
autonomous: noNeeds your brain: a product/design decision is required before anyone acts.Needs your brain: a product/design decision is required before anyone acts.enhancementNew feature or requestNew feature or requestpriority: mediumP2 - normal priorityP2 - normal prioritytriage: needs-decisionNeeds maintainer decision/design thoughtNeeds maintainer decision/design thought
Description
Metadata
Metadata
Assignees
Labels
autonomous: noNeeds your brain: a product/design decision is required before anyone acts.Needs your brain: a product/design decision is required before anyone acts.enhancementNew feature or requestNew feature or requestpriority: mediumP2 - normal priorityP2 - normal prioritytriage: needs-decisionNeeds maintainer decision/design thoughtNeeds maintainer decision/design thought
Hi, I prepared a theme feature branch in my fork, because the contributions are closed.
Branch:
https://github.com/alecuba16/jcode/tree/feature/themes-light-dark-config
Compare:
master...alecuba16:feature/themes-light-dark-config
Reason:
What the branch adds:
light,dark, andsystemthemes. Light is the current default/builtin theme./themecommand withstatus,light,dark,system, and custom theme names.display.themeconfig persistence.~/.jcode/themes/<name>.toml.A-Z,a-z,0-9,_,-) to avoid path traversal / drive-prefix issues.lightmode clears with an explicit light background instead of inheriting a dark terminal background.docs/themes.md.Validation run:
cargo fmt --package jcode-tui-style --package jcode-tui-render --package jcode-tuicargo test -p jcode-tui-stylecargo test -p jcode-tui-render clear_area_uses_active_theme_frame_backgroundcargo check -p jcode-tui-style -p jcode-tuicargo build -p jcode-tuiIf pull requests from forks are not enabled, could you please take a look at the branch and integrate it if it fits the project?