Fix Mamba TE backlight effects#960
Open
jooj211 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #424.
IssueHunt bounty: https://oss.issuehunt.io/r/1kc/razer-macos/issues/424
The Mamba Tournament Edition is already detected by product ID
0x0046, but OpenRazer exposes its lighting through thebacklight_*/matrix path rather than the logo/scroll/side LED path used by the generic mouse effect methods. That means the app shows effect options, but applying them does not change the mouse lighting.This change adds a device-level
lightingEffectTargetflag for mouse configs and routes standard mouse effects through the existing backlight/matrix addon calls when that flag is set. It also enables matrix brightness for the Mamba TE and hides legacy logo LED effects that do not apply to this device.Verification:
node --check src/main/device/razerdevicemouse.jsnode --check src/main/razerdevicemanager.jssrc/devices/mamba_te_wired.jsonwithJSON.parsegit diff --checkI do not have the physical Mamba TE hardware available, so this is based on the project's existing addon API plus OpenRazer's device mapping for
0x0046.