-
Notifications
You must be signed in to change notification settings - Fork 0
Make a Functional MADSci Module #3
Copy link
Copy link
Open
Labels
choreMaintenance, tooling improvements, etc.Maintenance, tooling improvements, etc.documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or request
Metadata
Metadata
Assignees
Labels
choreMaintenance, tooling improvements, etc.Maintenance, tooling improvements, etc.documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or request
Type
Fields
Give feedbackNo fields configured for Task.
Issues with the current implementation that need addressing:
Some things that can be done to address the above:
pyproject.tomlto includemadsci.node_module,madsci.common, andmadsci.clientdependencies, and remove thead_sdl.weipackageDockerfileto extend the MADSci docker image, rather than the WEI docker imagecompose.yamlto serve as a proper build and test harness for a MiR node service (existing maintainted MADSci modules can be used as a guide)wei.compose.yamltests/directorypre-commit run --all-filesmir_drivertomir_interfaceto match MADSci naming conventionspyproject.tomland portruff.tomlfrom an existing maintained MADSci moduleREADME.mdto ensure it provides useful and up-to-date documentation about the purpose and usage of the software.