PC0035 - No Warning if Temp Tabelle

[SKeiler]

Hi,

currently PC0035 (use autocalcfields) also refers to temp tables. But following some google search results, SetAutoCalcFields doenst't work for temporarry tables (but calcfields works if the record existing in the database). That should be fixed.

[Arthurvdv]

Thanks for the report, @SKeiler. I dug into this and you're right that there's a gap to address.

What I found

• PC0035 currently matches CalcFields on the loop variable by name only; it never checks whether the record is temporary. So it will fire on temporary records today.
• SetAutoCalcFields works by rewriting the SQL SELECT with JOINs so FlowFields are calculated when the record is retrieved from the database (per MS Docs and Kauffmann's write-up). Temporary records are in-memory and never issue that SELECT, so SetAutoCalcFields is effectively a no-op on them, while CalcFields still calculates against the FlowField's real source tables. That asymmetry is exactly why the suggestion would be wrong here.

Before I ship a fix I want to make sure I target the right scenario, because "temporary" in AL covers two distinct cases:

1. A variable declared temporary: MyRec: Record Customer temporary;
2. A table object with TableType = Temporary used through a normal Record X variable.

Could you share a minimal real-world AL snippet of the loop that triggers PC0035 for you? Two quick questions to go with it:

• Which of the two cases above is your record (or is it a normal DB record)?
• With your current CalcFields-in-loop code, are the FlowFields returning the correct values today?

That confirms the repro and lets me add the right exclusion plus regression tests. Thanks!

[SKeiler]

HI @Arthurvdv ,

It's case 1) and works in the case, that a record exists in the table which is same to the temporary record. Than the calcfields works (and is calculated on the table), but a Autocalcfields not (at least if i follow the documentation/google results).

It could also be testable on a customer or item record. Copy the record to a temp table and after that loop the temp records and try, if one of the existing flowfields are calculated.