[Bug]: Verify PC0036 - scenario marked as unsupported is used in the base app

[TKapitan]

Analyzer

PlatformCop

Issue type

False positive (diagnostic fires when it shouldn't)

Rule ID

PC0036

Description

The rule says "Calling SetRecord on a Page variable with a temporary record is not supported and will cause a runtime error. The Business Central runtime cannot bind a page to a temporary record instance via this method."

However, this approach is used in standard BC by Microsoft in multiple places and also in our apps too. I haven't see any issues with this, is this rule based on recent change or experience?

AL code to reproduce

Check codeunit 5332 "Lookup CRM Tables", the following procedures use this approach for conversion of option to mapping

• LookupCRMPaymentTerm(SavedCRMOptionId, CRMOptionId, CRMOptionCode, IntTableFilter)
• LookupCRMFreightTerm(SavedCRMOptionId, CRMOptionId, CRMOptionCode, IntTableFilter)
• LookupCRMShippingMethod(SavedCRMOptionId, CRMOptionId, CRMOptionCode, IntTableFilter)

Additional context

No response

[TKapitan]

I think this rule is wrong and there is misunderstanding in what the SetRecord does. Set record does not PASS a record to the page, it only SETs the pointer to selected record. And this works without any problems for temporary tables.

Obviously, if the temporary page does not have the selected record available it fails, but that is not linked to the SetRecord but to wrong design. If the page has the record available (as in example above where the page loads all records in LoadRecords() procedure the SetRecord works without any problems and correctly sets the pointer (currently selected record) to chosen record.

In my opinion this rule should not exist as it's based on misunderstanding what the SetRecord is for and how it works. Instead, maybe a better MS documentation for the function would be helpful to explain how it should be used.

The examples in https://alcops.dev/docs/analyzers/platformcop/pc0036/ are not ideal as they don't show correct use case.

The correct example should be a procedure where three temp records are created, passed to the page (reinserted to the page or copied with sharetables param) and then the SetRecord is used to preselect default record.

[Arthurvdv]

I'm quite sure this is a false positive. I would expect the diagnostic only to raise if the CRMPaymentTerms would be a temporary variable. I'll have a look into this and see if I can reproduce this.