From b3372a39ebf2e380c002973aa97014cbc46d2075 Mon Sep 17 00:00:00 2001
From: Arthur van de Vondervoort <arthur.van.de.vondervoort@gmail.com>
Date: Sat, 25 Apr 2026 17:34:06 +0200
Subject: [PATCH] fix: include ApprovalTests as transitive dependency

Remove PrivateAssets="all" and reduce ExcludeAssets to "build;buildTransitive"
on all three TFM-specific ApprovalTests PackageReference entries.

Previously, ApprovalTests was fully excluded from runtime assets, causing
FileNotFoundException when DiffHelper.TryToReportDiffWithExternalTool tried
to instantiate DiffReporter in consumer test projects.

The build/buildTransitive exclusion is retained to prevent ApprovalTests'
MSBuild targets from interfering with deterministic compilation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 src/RoslynTestKit/RoslynTestKit.csproj | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/RoslynTestKit/RoslynTestKit.csproj b/src/RoslynTestKit/RoslynTestKit.csproj
index 551b600..d377589 100644
--- a/src/RoslynTestKit/RoslynTestKit.csproj
+++ b/src/RoslynTestKit/RoslynTestKit.csproj
@@ -24,8 +24,7 @@
   <!-- ms-dynamics-smb.al-12.0.779795 with AssemblyFileVersion 12.0.11.58921 -->
   <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.1'">
     <PackageReference Include="ApprovalTests" Version="5.4.4"
-                      PrivateAssets="all"
-                      ExcludeAssets="build;buildTransitive;analyzers;contentFiles;native;runtime" />
+                      ExcludeAssets="build;buildTransitive" />
     <PackageReference Include="Microsoft.CodeAnalysis.Common" Version="3.1.0" />
     <Reference Include="Microsoft.Dynamics.Nav.CodeAnalysis">
         <SpecificVersion>False</SpecificVersion>
@@ -42,8 +41,7 @@
   <!-- ms-dynamics-smb.al-16.0.1463980 with AssemblyFileVersion 16.0.22.22232 -->
   <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
     <PackageReference Include="ApprovalTests" Version="5.8.0"
-                      PrivateAssets="all"
-                      ExcludeAssets="build;buildTransitive;analyzers;contentFiles;native;runtime" />
+                      ExcludeAssets="build;buildTransitive" />
     <PackageReference Include="Microsoft.CodeAnalysis.Common" Version="4.8.0" />
     <Reference Include="Microsoft.Dynamics.Nav.CodeAnalysis">
         <SpecificVersion>False</SpecificVersion>
@@ -61,8 +59,7 @@
   <!-- ms-dynamics-smb.al-17.0.2273547 -->
   <ItemGroup Condition="'$(TargetFramework)' == 'net10.0'">
     <PackageReference Include="ApprovalTests" Version="5.8.0"
-                      PrivateAssets="all"
-                      ExcludeAssets="build;buildTransitive;analyzers;contentFiles;native;runtime" />
+                      ExcludeAssets="build;buildTransitive" />
     <PackageReference Include="Microsoft.CodeAnalysis.Common" Version="4.14.0" />
     <Reference Include="Microsoft.Dynamics.Nav.CodeAnalysis">
         <SpecificVersion>False</SpecificVersion>