Skip to content

Global RMS output argument design #2

@ooreilly

Description

@ooreilly

The plan contains a convenience pointer that holds the RMS value on the device: hipCompress(scale, plan->d_rms, d_data, d_compressed,plan,user_stream) This design is awkward because the function already takes in the plan and hence it could read the RMS value from there. However, the copy function must take the RMS as user input because that gives the user control of whether they want to compute the global RMS or not. We have the following proposals:

  1. Keep as is.
  2. Always compute the global RMS value during the wavelet copy layout and store it in the plan. Remove the explicit output arguments for the RMS value in the copy and compression functions. Performance impact is expected to be negligible.
  3. Only remove the RMS output argument from the compression function.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions