Skip to content

Commit 5be8d0b

Browse files
fixes
1 parent acfe837 commit 5be8d0b

2 files changed

Lines changed: 15 additions & 9 deletions

File tree

docs/how/cmake_winapp/typescript.cmake

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,9 @@ macro(add_tsc_files subpath)
2525
file(GLOB TSC_SRC "${fileSelectPath}/*.${TSExt}")
2626

2727
if (CMAKE_BUILD_TYPE STREQUAL "Release")
28-
set (TS_FLAGS "-opt")
29-
set (LLC_FLAGS "")
28+
set (TS_FLAGS "--opt")
3029
else()
31-
set (TS_FLAGS "")
32-
set (LLC_FLAGS "--experimental-debug-variable-locations")
30+
set (TS_FLAGS "--opt_level=0 --di")
3331
endif()
3432

3533
set (TS_FILES)
@@ -49,8 +47,7 @@ macro(add_tsc_files subpath)
4947

5048
add_custom_command(
5149
OUTPUT "${obj_file}"
52-
#COMMAND ${CMAKE_COMMAND} -E echo "Compiling ${source_file} to ${obj_file}"
53-
COMMAND "${TSC_APP}" --emit=obj -o="${obj_file}" ${TS_FLAGS} ${LLC_FLAGS} "${source_file}"
50+
COMMAND "${TSC_APP}" --emit=obj -o="${obj_file}" ${TS_FLAGS} "${source_file}"
5451
DEPENDS "${source_file}"
5552
BYPRODUCTS "${obj_file}"
5653
COMMENT "Compiling ${source_file} to ${obj_file}"

tsc/lib/TypeScript/MLIRGen.cpp

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,8 @@ class MLIRGenImpl
198198

199199
filesToProcess.pop_back();
200200

201-
std::string ignored;
202-
auto id = sourceMgr.AddIncludeFile(std::string(fullPath), SMLoc(), ignored);
201+
std::string actualFilePath;
202+
auto id = sourceMgr.AddIncludeFile(std::string(fullPath), SMLoc(), actualFilePath);
203203
if (!id)
204204
{
205205
emitError(location, "can't open file: ") << fullPath;
@@ -210,7 +210,7 @@ class MLIRGenImpl
210210

211211
Parser parser;
212212
auto includeFile =
213-
parser.parseSourceFile(includeFileName, stows(sourceBuf->getBuffer().str()), ScriptTarget::Latest);
213+
parser.parseSourceFile(ConvertUTF8toWide(actualFilePath), stows(sourceBuf->getBuffer().str()), ScriptTarget::Latest);
214214
for (auto refFile : includeFile->referencedFiles)
215215
{
216216
filesToProcess.push_back(refFile.fileName);
@@ -404,6 +404,10 @@ class MLIRGenImpl
404404

405405
for (auto includeFile : includeFiles)
406406
{
407+
MLIRValueGuard<llvm::StringRef> vgFileName(fileName);
408+
auto fileNameUtf8 = convertWideToUTF8(includeFile->fileName);
409+
fileName = fileNameUtf8;
410+
407411
if (failed(mlirGen(includeFile->statements, genContextPartial)))
408412
{
409413
outputDiagnostics(postponedMessages, 1);
@@ -453,8 +457,13 @@ class MLIRGenImpl
453457

454458
for (auto includeFile : includeFiles)
455459
{
460+
MLIRValueGuard<llvm::StringRef> vgFileName(fileName);
461+
auto fileNameUtf8 = convertWideToUTF8(includeFile->fileName);
462+
fileName = fileNameUtf8;
463+
456464
if (failed(mlirGen(includeFile->statements, genContext)))
457465
{
466+
outputDiagnostics(postponedMessages, 1);
458467
return mlir::failure();
459468
}
460469
}

0 commit comments

Comments
 (0)