added test for path.app

Author: ASDAlexander77

tsc/lib/TypeScript/MLIRGen.cpp

@@ -4249,12 +4249,14 @@ class MLIRGenImpl
                 // cast from optional<T> type
                 if (auto leftOptType = leftExpressionValue.getType().dyn_cast_or_null<mlir_ts::OptionalType>())
                 {
-                    leftExpressionValue = cast(loc(leftExpression), leftOptType.getElementType(), leftExpressionValue, genContext);
+                    leftExpressionValue =
+                        builder.create<mlir_ts::ValueOp>(loc(leftExpression), leftOptType.getElementType(), leftExpressionValue);
                 }
 
                 if (auto rightOptType = rightExpressionValue.getType().dyn_cast_or_null<mlir_ts::OptionalType>())
                 {
-                    rightExpressionValue = cast(loc(rightExpression), rightOptType.getElementType(), rightExpressionValue, genContext);
+                    rightExpressionValue =
+                        builder.create<mlir_ts::ValueOp>(loc(rightExpression), rightOptType.getElementType(), rightExpressionValue);
                 }
             }
         }
@@ -4265,8 +4267,10 @@ class MLIRGenImpl
             {
                 if (auto rightOptType = rightExpressionValue.getType().dyn_cast_or_null<mlir_ts::OptionalType>())
                 {
-                    leftExpressionValue = cast(loc(leftExpression), leftOptType.getElementType(), leftExpressionValue, genContext);
-                    rightExpressionValue = cast(loc(rightExpression), rightOptType.getElementType(), rightExpressionValue, genContext);
+                    leftExpressionValue =
+                        builder.create<mlir_ts::ValueOp>(loc(leftExpression), leftOptType.getElementType(), leftExpressionValue);
+                    rightExpressionValue =
+                        builder.create<mlir_ts::ValueOp>(loc(rightExpression), rightOptType.getElementType(), rightExpressionValue);
                 }
             }
         }
@@ -5029,7 +5033,7 @@ class MLIRGenImpl
 
             // value if true
 
-            auto innerFuncRef = cast(location, optFuncRef.getElementType(), funcRefValue, genContext);
+            auto innerFuncRef = builder.create<mlir_ts::ValueOp>(location, optFuncRef.getElementType(), funcRefValue);
 
             auto hasReturn = false;
             auto value =
@@ -8681,14 +8685,6 @@ class MLIRGenImpl
             return value;
         }
 
-        if (auto optType = value.getType().dyn_cast<mlir_ts::OptionalType>())
-        {
-            if (optType.getElementType() == type)
-            {
-                llvm_unreachable("for getting value from optional - use ValueOpLowering");
-            }
-        }
-
         // class to string
         if (auto stringType = type.dyn_cast_or_null<mlir_ts::StringType>())
         {

tsc/test/tester/CMakeLists.txt

@@ -201,6 +201,7 @@ add_test(NAME test-compile-51-exceptions COMMAND test-runner -llc "${PROJECT_SOU
 add_test(NAME test-compile-Grammar_and_types COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/Grammar_and_types.ts")
 add_test(NAME test-compile-StackTest COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/00stack_test.ts")
 add_test(NAME test-compile-Raytrace COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/raytrace.ts")
+add_test(NAME test-compile-Path COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/path.ts")
 add_test(NAME test-compile-Print-Bug-01 COMMAND test-runner "${PROJECT_SOURCE_DIR}/test/tester/tests/01print-bug.ts")
 
 add_test(NAME test-jit-00-print COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/00print.ts")
@@ -338,4 +339,5 @@ endif()
 add_test(NAME test-jit-Grammar_and_types COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/Grammar_and_types.ts")
 add_test(NAME test-jit-StackTest COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/00stack_test.ts")
 add_test(NAME test-jit-Raytrace COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/raytrace.ts")
+add_test(NAME test-jit-Path COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/path.ts")
 add_test(NAME test-jit-Print-Bug-01 COMMAND test-runner -jit "${PROJECT_SOURCE_DIR}/test/tester/tests/01print-bug.ts")

tsc/test/tester/tests/path.ts

@@ -0,0 +1,51 @@
+export type Maybe<T> = null | undefined | T;
+
+export interface Path {
+    readonly prev: Path | undefined;
+    readonly key: string | number;
+    readonly typename: string | undefined;
+}
+
+/**
+ * Given a Path and a key, return a new Path containing the new key.
+ */
+export function addPath(
+    prev: Readonly<Path> | undefined,
+    key: string | number,
+    typename: string | undefined,
+): Path {
+    return { prev, key, typename };
+}
+
+/**
+ * Given a Path, return an Array of the path keys.
+ */
+export function pathToArray(
+    path: Maybe<Readonly<Path>>,
+): Array<string | number> {
+    let curr = path;
+    let flattened = <typeof curr.key[]>[];
+    while (curr) {
+        flattened.push(curr.key);
+        curr = curr.prev;
+    }
+    //flattened.reverse();
+    return flattened;
+}
+
+function main() {
+    let pathArray = pathToArray({
+        key: "path",
+        prev: undefined,
+        typename: undefined,
+    });
+    for (let x of pathArray) {
+        if (typeof x == "string") {
+            assert(x == "path");
+        }
+
+        print(x);
+    }
+
+    print("done.");
+}