Uds 1649 - feat(unity-react-core): extend tooltip to component wrapper#1606
Open
scott-williams-az wants to merge 2 commits intodevfrom
Open
Uds 1649 - feat(unity-react-core): extend tooltip to component wrapper#1606scott-williams-az wants to merge 2 commits intodevfrom
scott-williams-az wants to merge 2 commits intodevfrom
Conversation
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1606/index.html |
davidornelas11
requested changes
Jan 26, 2026
Contributor
davidornelas11
left a comment
davidornelas11
left a comment
There was a problem hiding this comment.
Looks good! Should we also add proptypes to the unity react core component?
mlsamuelson
approved these changes
Jan 27, 2026
Member
|
Changes coming. Don't merge yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tooltip component accepts child components. Looking at this again, I am thinking the tooltip component should probably limit what children it accepts. Could use some input.
Links