Draft
Conversation
…er for sections N
Logic only lives in unity-bootstrap-theme js to be more in line with how the rest of components behave BREAKING CHANGE: All attach/detach and scroll logic is removed from anchor menu react component and relies on unity-bootstrap-theme javascript
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1622/index.html |
| if (!navbar) { | ||
| console.warn( | ||
| "Anchor menu initialization failed: required elements not found" | ||
| ); |
Contributor
There was a problem hiding this comment.
Lets remove this since it warns anytime an anchor menu is not found and it just adds noise. (pages that do not have an anchor menu on purposed get a warning)
Contributor
|
We can go with patching existing functions, but I wonder if we can start using some modern solutions like dynamically finding any heading elements and using scroll-padding-top. I put together a POC https://github.com/ASU/asu-unity-stack/compare/anchor-menu-fix...anchor-menu-POC?expand=1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Important Reminders
Links