Skip to content

1.39.5 cmake config unconditionally tries to find X11 #2986

Description

@anderslanglands

In one of my builds I'm doing:

-DMATERIALX_BUILD_RENDER=OFF
-DMATERIALX_BUILD_RENDER_PLATFORMS=OFF
-DMATERIALX_BUILD_VIEWER=OFF
-DMATERIALX_BUILD_GRAPH_EDITOR=OFF

in order to get a headless library that will link without x11.

In 1.39.5:

if(UNIX AND NOT APPLE)

if(UNIX AND NOT APPLE)
    find_dependency(X11 REQUIRED COMPONENTS Xt)
    if("RenderGlsl" IN_LIST MaterialX_FIND_COMPONENTS)
        find_dependency(OpenGL REQUIRED)
        set(MaterialX_RenderGlsl_FOUND TRUE)
    endif()
endif()

Should I think be something like:

if(UNIX AND NOT APPLE AND (TARGET MaterialXRenderHw OR TARGET MaterialXRenderGlsl))
    find_dependency(X11 REQUIRED COMPONENTS Xt)
endif()

if(TARGET MaterialXRenderGlsl)
    find_dependency(OpenGL REQUIRED)
    if("RenderGlsl" IN_LIST MaterialX_FIND_COMPONENTS)
        set(MaterialX_RenderGlsl_FOUND TRUE)
    endif()
endif()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions