crash in blender 5.0.0 with opencolorio 2.5.1

[darix]

#0  __GI_abort () at abort.c:95
#1  0x00007f8edecb2cf4 in __gnu_cxx::__verbose_terminate_handler () at ../../../../libstdc++-v3/libsupc++/vterminate.cc:95
#2  0x00007f8edecc53bc in __cxxabiv1::__terminate (handler=<optimized out>) at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:48
#3  0x00007f8edecb287a in std::terminate () at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:58
#4  0x00007f8edecc5668 in __cxxabiv1::__cxa_throw (obj=<optimized out>, tinfo=0x7f8ee2ac02a8 <typeinfo for OpenColorIO_v2_5::Exception>, dest=0x7f8ee2771510 <OpenColorIO_v2_5::Exception::~Exception()>) at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:98
#5  0x00007f8ee26a2da1 in OpenColorIO_v2_5::GPUShaderImpl::PrivateImpl::getTextureShaderBindingIndex (this=0x7f8e52cd71e0, index=<optimized out>) at /usr/include/c++/15/bits/allocator.h:189
#6  0x00007f8ee27f1b42 in OpenColorIO_v2_5::GenericGpuShaderDesc::getTextureShaderBindingIndex (this=0x7f8e525eec80, index=<optimized out>) at /usr/src/debug/OpenColorIO-2.5.1/src/OpenColorIO/GpuShader.cpp:605
#7  0x000055566904d4dc in blender::ocio::(anonymous namespace)::create_gpu_textures (textures=..., shader_desc=...) at /usr/src/debug/blender-5.0.0/source/blender/imbuf/opencolorio/intern/libocio/libocio_gpu_shader_binder.cc:167
#8  0x0000555669077c63 in blender::ocio::LibOCIOGPUShaderBinder::construct_shader_for_processors (this=this@entry=0x7f8ec398fa40, display_shader=..., processor_to_scene_linear=..., processor_to_display=..., additional_defines=...)
    at /usr/src/debug/blender-5.0.0/source/blender/imbuf/opencolorio/intern/libocio/libocio_gpu_shader_binder.cc:196
#9  0x000055566907801c in blender::ocio::LibOCIOGPUShaderBinder::construct_display_shader (this=0x7f8ec398fa40, display_shader=...) at /usr/src/debug/blender-5.0.0/source/blender/imbuf/opencolorio/intern/libocio/libocio_gpu_shader_binder.cc:246
#10 0x0000555668766fea in blender::ocio::GPUShaderBinder::display_bind (this=0x7f8ec398fa40, display_parameters=...) at /usr/src/debug/blender-5.0.0/source/blender/imbuf/opencolorio/intern/gpu_shader_binder.cc:412
#11 IMB_colormanagement_setup_glsl_draw_from_space (view_settings=<optimized out>, display_settings=<optimized out>, from_colorspace=0x0, dither=0, predivide=false, do_overlay_merge=true)
    at /usr/src/debug/blender-5.0.0/source/blender/imbuf/intern/colormanagement.cc:4491
#12 0x000055566a12f830 in gpu_viewport_draw_colormanaged (viewport=0x7f8e529669c8, view=<optimized out>, rect_pos=0x7ffc6c00af80, rect_uv=0x7ffc6c00af90, display_colorspace=true, do_overlay_merge=true)
    at /usr/src/debug/blender-5.0.0/source/blender/gpu/intern/gpu_viewport.cc:464
#13 0x00005556687d70f7 in GPU_viewport_draw_to_screen_ex (display_colorspace=true, do_overlay_merge=true, viewport=<optimized out>, view=<optimized out>, rect=0x7f8e909411c8) at /usr/src/debug/blender-5.0.0/source/blender/gpu/intern/gpu_viewport.cc:541
#14 GPU_viewport_draw_to_screen (viewport=<optimized out>, view=<optimized out>, rect=0x7f8e909411c8) at /usr/src/debug/blender-5.0.0/source/blender/gpu/intern/gpu_viewport.cc:547
#15 wm_draw_region_blit (region=0x7f8e90941120, view=<optimized out>) at /usr/src/debug/blender-5.0.0/source/blender/windowmanager/intern/wm_draw.cc:835
#16 wm_draw_window_onscreen (C=0x7f8ec0f24488, win=0x7f8e908bea60, view=-1) at /usr/src/debug/blender-5.0.0/source/blender/windowmanager/intern/wm_draw.cc:1127
#17 0x00005556687fd1e5 in wm_draw_window (C=0x7f8ec0f24488, win=0x7f8e908bea60) at /usr/src/debug/blender-5.0.0/source/blender/windowmanager/intern/wm_draw.cc:1243
#18 wm_draw_update (C=<optimized out>) at /usr/src/debug/blender-5.0.0/source/blender/windowmanager/intern/wm_draw.cc:1655
#19 0x0000555667c3b2ab in WM_main (C=<optimized out>) at /usr/src/debug/blender-5.0.0/source/blender/windowmanager/intern/wm.cc:601
#20 main (argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/blender-5.0.0/source/creator/creator.cc:624

[darix]

same with 4.5.1

[doug-walker]

@darix , it would be helpful if you could provide some context for this. Apparently you recompiled Blender with the latest version, and then what did you do to get the crash?

[darix]

oops. right. I was a bit in a rush. this crash triggers directly during startup.

[doug-walker]

@darix , could you confirm that you recompiled Blender with the OCIO 2.5.1 header files rather than simply swapping the library file (DLL)?

[darix]

it looks like the blender package was not rebuilt with the package as the so version has not changed.

[lgritz]

Does OCIO make a guarantee of 100% ABI back-compatibility for 3rd digit changes?

[darix]

a good question. but if the so version didnt change it should be no? and that is is still 2.5.

for the record: rebuild seems to fix it. but imho the soversion needs to be bumped.

[doug-walker]

@lgritz , our goal has been to preserve ABI compatibility for 3rd-digit changes. When we released 2.5.1, it was my understanding that that was the case. However, we later learned that it is not ABI compatible for clients using the GPU renderer (which includes Blender) due to a change we made to address a problem with the Vulkan implementation that was released in 2.5.0. We are still in discussion with the TSC about how we will handle that but we will certainly be communicating about it this week.

[darix]

your external soversion is the 2nd symlink with .2.5.

readelf -d /usr/lib64/libOpenColorIO.so.2.5 | grep SONAME
 0x000000000000000e (SONAME)             Library soname: [libOpenColorIO.so.2.5]

we will rebuild our 2 blender packages as soon as possible and release them.

[lgritz]

@doug-walker Understood. We've all gotten caught by this kind of thing at some point.

Excuse me if you already do this and I just don't know, but if you don't have an automated way to test the ABI compatibility before releases (or indeed, for any PR), I can point you to the method we use for OIIO to ensure continuity of ABI compatibility as part of CI.

[doug-walker]

@lgritz , the project is not using an ABI checker (though clearly that is something that should be improved), and I was discussing options with a colleague this afternoon.

Thank you for your suggestion, I found the test you are doing in the OIIO CI and I expect we should be able to do something similar for OCIO to avoid this problem in the future.