-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
configurationConfiguration ManagementConfiguration ManagementenhancementNew feature or requestNew feature or requestsecurityCode SecurityCode Security
Description
Many configuration values are hardcoded throughout the codebase instead of being managed through a proper configuration system.
Current Issues
- Hardcoded channel IDs in main.py
- Hardcoded alert thresholds in alerts.py
- Hardcoded timeframes and lookback periods
- Discord role IDs in the code
Proposed Solution
- Create a proper configuration management system
- Move all configuration to YAML/ENV files
- Implement configuration validation
- Add configuration documentation
Example configuration structure:
discord:
channels:
money_flow: 1186336783261249638
alerts:
main: 1217104257216679987
rvol: 1217105162351673455
macd: 1217105204856488018
vwap: 1217483711893733478
analysis:
timeframe: 4h
lookback_days: 31
thresholds:
rvol:
up: 1.5
extreme: 2.4
down: 0.3
vwap:
above: 1.01
below: 0.99
large_order: 100000Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
configurationConfiguration ManagementConfiguration ManagementenhancementNew feature or requestNew feature or requestsecurityCode SecurityCode Security