Final review updates

Author: gregsvo

README.md

@@ -31,16 +31,16 @@ import postmark
 from dotenv import load_dotenv
 
 load_dotenv()
-client = postmark.ServerClient(os.environ["POSTMARK_SERVER_TOKEN"])
 
 async def main():
-    response = await client.outbound.send({
-        "sender": "sender@example.com",
-        "to": "recipient@example.com",
-        "subject": "Hello from Postmark",
-        "text_body": "Sent with the Postmark Python SDK.",
-    })
-    print(f"Sent: {response.message_id}")
+    async with postmark.ServerClient(os.environ["POSTMARK_SERVER_TOKEN"]) as client:
+        response = await client.outbound.send({
+            "sender": "sender@example.com",
+            "to": "recipient@example.com",
+            "subject": "Hello from Postmark",
+            "text_body": "Sent with the Postmark Python SDK.",
+        })
+        print(f"Sent: {response.message_id}")
 
 asyncio.run(main())
 ```
@@ -55,8 +55,16 @@ asyncio.run(main())
 ```python
 import postmark
 
-client  = postmark.ServerClient(os.environ["POSTMARK_SERVER_TOKEN"])
-account = postmark.AccountClient(os.environ["POSTMARK_ACCOUNT_TOKEN"])
+# Use as async context managers to ensure connections are closed
+async with postmark.ServerClient(os.environ["POSTMARK_SERVER_TOKEN"]) as client:
+    ...
+
+async with postmark.AccountClient(os.environ["POSTMARK_ACCOUNT_TOKEN"]) as account:
+    ...
+
+# Or call close() explicitly when done
+client = postmark.ServerClient(os.environ["POSTMARK_SERVER_TOKEN"])
+await client.close()
 ```
 
 ## Development

postmark/exceptions.py

@@ -80,7 +80,9 @@ def __init__(
         super().__init__(message, error_code, http_status, request_id)
         match = re.search(r"Found inactive addresses: ([^.]+)", message)
         self.inactive_recipients: list[str] = (
-            [addr.strip() for addr in match.group(1).split(",")] if match else []
+            [a for addr in match.group(1).split(",") if (a := addr.strip())]
+            if match
+            else []
         )
 
 

postmark/models/outbound/manager.py

@@ -97,6 +97,10 @@ async def send_batch(
         Send up to 500 different emails in a single request.
         Use this when each recipient needs a **completely different** message.
         For sending the **same message** to many recipients, use send_bulk().
+
+        The API returns HTTP 200 even when individual messages fail. Check
+        each ``SendResponse.success`` (or ``error_code``) in the returned list
+        to detect per-message delivery errors.
         """
         if len(messages) > 500:
             raise ValueError("Batch size cannot exceed 500 messages")

tests/test_account_client.py

@@ -137,6 +137,11 @@ async def test_close_calls_aclose(self, client):
             await client.close()
             mock_aclose.assert_called_once()
 
+    @pytest.mark.asyncio
+    async def test_close_twice_does_not_raise(self, client):
+        await client.close()
+        await client.close()
+
     @pytest.mark.asyncio
     async def test_async_context_manager(self):
         async with AccountClient(account_token="test-account-token") as client:

tests/test_server_client.py

@@ -120,6 +120,11 @@ async def test_close_calls_aclose(self, client):
             await client.close()
             mock_aclose.assert_called_once()
 
+    @pytest.mark.asyncio
+    async def test_close_twice_does_not_raise(self, client):
+        await client.close()
+        await client.close()
+
     @pytest.mark.asyncio
     async def test_async_context_manager(self):
         async with ServerClient(server_token="test-token") as client: