Skip to content

fix: target macOS 14 for swift helper #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimeToBuildBob wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: target macOS 14 for swift helper #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c87f9a8
fix: target macOS 14 for swift helper
TimeToBuildBob May 7, 2026
07a577b
fix(ci): scope macOS deployment target in workflow
TimeToBuildBob May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,16 @@ jobs:
# seen in: https://github.com/ActivityWatch/aw-watcher-window/actions/runs/5891369412/job/15978283144
pip install poetry==1.3.2
source venv/bin/activate || source venv/Scripts/activate
make build
if [ "${{ runner.os }}" = "macOS" ]; then
MACOSX_DEPLOYMENT_TARGET=14.0 make build
else
make build
fi
- name: Check macOS deployment target
if: runner.os == 'macOS'
shell: bash
run: |
otool -l aw_watcher_window/aw-watcher-window-macos | grep -A4 'LC_BUILD_VERSION' | grep 'minos 14.0'
- name: Run tests
shell: bash
run: |
Expand All @@ -45,7 +54,11 @@ jobs:
shell: bash
run: |
source venv/bin/activate || source venv/Scripts/activate
make package
if [ "${{ runner.os }}" = "macOS" ]; then
MACOSX_DEPLOYMENT_TARGET=14.0 make package
else
make package
fi
- name: Test package
shell: bash
run: |
Expand Down
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
.PHONY: build test package clean

MACOSX_DEPLOYMENT_TARGET ?= 14.0

build:
poetry install
# if macOS, build swift
Expand All @@ -10,7 +12,7 @@ build:
build-swift: aw_watcher_window/aw-watcher-window-macos

aw_watcher_window/aw-watcher-window-macos: aw_watcher_window/macos.swift
swiftc $^ -o $@
swiftc -target "$(shell uname -m)-apple-macosx$(MACOSX_DEPLOYMENT_TARGET)" $^ -o $@

test:
aw-watcher-window --help
Expand Down
Loading