From 383aaa721d5b67fd51b6b1948752030794e9a067 Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 13 Jul 2026 18:39:27 +0000 Subject: [PATCH] notebook-query: import ThinkingStyle from its canonical module (fix deploy build) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The cockpit-server release build (Railway) failed: error[E0432]: unresolved import `lance_graph_planner::api::ThinkingStyle` lance-graph moved `ThinkingStyle` behind an `api` re-export that POSTDATES the lance-graph rev this repo pins, so importing it from `lance_graph_planner::api` no longer resolves against the pinned dependency. The enum itself has always lived at `lance_graph_planner::thinking::style::ThinkingStyle` (pub mod thinking → pub mod style), which resolves against every lance-graph version — the compiler's own suggestion. Import ThinkingStyle from that canonical path in the two `planner`-gated call sites (diagnostics.rs, lib.rs); Planner/PlanResult still come from `api`. No behaviour change — same type, robust import path. Unblocks the cockpit-server deploy (and any q2 build against the pinned lance-graph). Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_012jEwwaT5JZ5x8qWvcnaMYC --- crates/stubs/notebook-query/src/diagnostics.rs | 7 ++++++- crates/stubs/notebook-query/src/lib.rs | 3 ++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/crates/stubs/notebook-query/src/diagnostics.rs b/crates/stubs/notebook-query/src/diagnostics.rs index 43c7a982f..873ba61d9 100644 --- a/crates/stubs/notebook-query/src/diagnostics.rs +++ b/crates/stubs/notebook-query/src/diagnostics.rs @@ -9,7 +9,12 @@ use serde::{Deserialize, Serialize}; #[cfg(feature = "planner")] -use lance_graph_planner::api::{Planner, ThinkingStyle, PlanResult}; +use lance_graph_planner::api::{Planner, PlanResult}; +// ThinkingStyle from its canonical module, not the api re-export — the re-export was +// added to lance-graph after this pin, so importing from `api` breaks the build against +// the pinned lance-graph; `thinking::style` exists in every version. +#[cfg(feature = "planner")] +use lance_graph_planner::thinking::style::ThinkingStyle; // ── Strategy Self-Check ────────────────────────────────────────────────────── diff --git a/crates/stubs/notebook-query/src/lib.rs b/crates/stubs/notebook-query/src/lib.rs index 6933e0611..78fe31aab 100644 --- a/crates/stubs/notebook-query/src/lib.rs +++ b/crates/stubs/notebook-query/src/lib.rs @@ -358,7 +358,8 @@ fn run_planner_with_options( felt_competence: Option, demonstrated_competence: Option, ) -> Option { - use lance_graph_planner::api::{Planner, ThinkingStyle}; + use lance_graph_planner::api::Planner; + use lance_graph_planner::thinking::style::ThinkingStyle; // canonical path; api re-export postdates the pin let planner = Planner::new();