-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
Description
Missing Tests: Zero Coverage Across All Packages
Description
Running go test ./... reports [no test files] for every package. A governance and security runtime with no tests is a significant reliability and safety risk.
Affected packages (all of them)
internal/governance— policy evaluation engine (core safety logic)internal/intent— format-agnostic intent parser (parsing bugs = governance bypass)internal/normalizer— action classification and fingerprintinginternal/correction— escalation and retry logicinternal/agent— main execution loopinternal/scheduler— agent scheduling and concurrencyinternal/tools— tool dispatch (file read/write, shell execution)
Highest-priority tests needed
internal/governance: Ensuredenypolicies block inenforcemode;monitormode allows through;file-write-constraintspath matching works correctly.internal/intent: Parser handles JSON blocks, XML tags, bare JSON, OpenAI function_call; unknown formats return nil. A parsing regression = governance bypass.internal/normalizer:classifyShellRiskcorrectly identifies destructive vs read-only.internal/correction: Lockdown triggers at 10 denials; escalation levels correct.
Why this matters
ShellForge's security model depends on the intent parser and governance engine working correctly. A governance bug returning Allowed: true for a deny policy in enforce mode silently bypasses all protection.
Reactions are currently unavailable