You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Track follow-up reviews feature enhancements around stale review delivery and batch hardening.
The new multi-PR batch delivery path should suppress changes_requested results for older PR heads by checking (pr_url, target_sha) against the current PR head before notifying the worker. This issue tracks keeping that invariant explicit across all review delivery paths and future review enhancements.
Migrated from aoagents/ReverbCode/issues/407
Source: aoagents/ReverbCode#407
Summary
Track follow-up reviews feature enhancements around stale review delivery and batch hardening.
The new multi-PR batch delivery path should suppress
changes_requestedresults for older PR heads by checking(pr_url, target_sha)against the current PR head before notifying the worker. This issue tracks keeping that invariant explicit across all review delivery paths and future review enhancements.Problem
Example flow:
sha-old.sha-new.sha-new.changes_requestedforsha-old.AO should not notify the worker to address stale feedback for the old SHA.
Desired Behavior
Before sending any worker notification for review feedback:
changes_requestedrun.(pr_url, target_sha)still match the current PR head.This should remain true for batch delivery and any legacy/single-run delivery path that can still handle empty
batch_idrows.Acceptance Criteria
changes_requestedreview for the current PR head sends a worker notification.changes_requestedreview for an older SHA does not send a worker notification.changes_requestedruns.Related Context
This came out of the multi-PR review batching design for issue #395. It is one item in a broader reviews feature enhancements bucket.