Skip to content

fix(frontend): resolve ESLint react-hooks/exhaustive-deps warning in ReportViewer #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlanFokCo merged 1 commit into from
May 23, 2026
Merged

fix(frontend): resolve ESLint react-hooks/exhaustive-deps warning in ReportViewer #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions web_strategy_studio/frontend/src/components/ReportViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* ReportViewer — native Lightweight Charts rendering for backtest reports.
* Replaces the iframe approach in ReportLinkModal for full interactivity.
*/
import { useEffect, useRef, useState } from "react";
import { useCallback, useEffect, useRef, useState } from "react";
import { createChart, ColorType, CrosshairMode, LineStyle } from "lightweight-charts";
import type { IChartApi } from "lightweight-charts";

Expand Down Expand Up @@ -98,11 +98,11 @@ export default function ReportViewer({ runId, jsonUrl }: { runId: string; jsonUr
const isTablet = viewportWidth >= 480 && viewportWidth < 768;

// Dynamic chart height based on viewport
function getChartHeight(base: number): number {
const getChartHeight = useCallback((base: number): number => {
if (isPhone) return Math.round(base * 0.58);
if (isTablet) return Math.round(base * 0.75);
return base;
}
}, [isPhone, isTablet]);

// Fetch report JSON data
useEffect(() => {
Expand Down Expand Up @@ -333,7 +333,7 @@ export default function ReportViewer({ runId, jsonUrl }: { runId: string; jsonUr
chartsRef.current.forEach((c) => c.remove());
chartsRef.current = [];
};
}, [data]);
}, [data, getChartHeight]);

if (loading) {
return (
Expand Down