Добавлен ендпоинт для получения имен сотрудников#11
Open
Aleksei-Iagur wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
Добавлены новые возможности для управления ролями и получения полных имён сотрудников.
- Добавлена DTO-модель CreateRoleRequest и новый POST-эндпоинт CreateRoleAsync в RolesController
- Добавлен GET-эндпоинт GetEmployeeFullNamesAsync в EmployeesController
- Расширен интерфейс репозитория методом AddAsync и добавлен stub-реализация в InMemoryRepository
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/PromoCodeFactory.WebHost/Models/CreateRoleRequest.cs | Новая модель CreateRoleRequest с атрибутом [Required] для Name |
| src/PromoCodeFactory.WebHost/Controllers/RolesController.cs | Унаследован от ControllerBase и добавлен POST /api/v1/roles |
| src/PromoCodeFactory.WebHost/Controllers/EmployeesController.cs | Добавлен GET /api/v1/employees/fullnames |
| src/PromoCodeFactory.DataAccess/Repositories/InMemoryRepository.cs | Data заменён на List и добавлен stub AddAsync |
| src/PromoCodeFactory.Core/Abstractions/Repositories/IRepository.cs | В интерфейс добавлен метод AddAsync |
| .github/copilot-instructions.md | Инструкция для код-ревью на русском языке |
Comments suppressed due to low confidence (3)
src/PromoCodeFactory.WebHost/Controllers/RolesController.cs:63
- Для соответствия REST-конвенциям лучше возвращать статус 201 Created и заголовок Location с помощью CreatedAtAction, например: return CreatedAtAction(nameof(GetRolesAsync), new { id = role.Id }, response).
return new RoleItemResponse
src/PromoCodeFactory.WebHost/Controllers/RolesController.cs:51
- Не найдено тестов для нового POST-эндпоинта CreateRoleAsync. Рекомендуется добавить модульные или интеграционные тесты, покрывающие создание роли и валидацию входных данных.
[HttpPost]
src/PromoCodeFactory.WebHost/Controllers/EmployeesController.cs:78
- Не найден тест для эндпоинта GetEmployeeFullNamesAsync. Рекомендуется добавить тест, проверяющий корректность возвращаемого списка полных имён сотрудников.
[HttpGet("fullnames")]
…y.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.