[Common] Add zdc-extra-table-reader task#16028
Open
udmitrie wants to merge 14 commits into
Open
Conversation
zdc-extra-table-reader is needed to read AOD/ZDCEXTRA derived data and proceed with multistep calibration (Q-vectors recentering) of ZDC data
|
O2 linter results: ❌ 1 errors, |
Refactor logging and constants in zdcExtraTableReader. Replaced std::cerr logging with LOGF for error handling and updated constant names for consistency.
udmitrie
requested review from
a team,
alibuild,
ddobrigk,
dsekihat,
iarsene,
jgrosseo and
ktf
as code owners
Add check number of fired towers with isZN*SpDeterminable (to reconstruct Q-vector at least 2 fired towers needed); Replace FindBin with FindFixBin; update variables.
Please consider the following formatting changes to AliceO2Group#16028
Contributor
Author
|
Dear code owners, There are no O2 linter errors connected to my changes. |
vkucera
reviewed
May 6, 2026
vkucera
reviewed
May 6, 2026
vkucera
reviewed
May 6, 2026
vkucera
reviewed
May 6, 2026
vkucera
reviewed
May 6, 2026
vkucera
reviewed
May 6, 2026
vkucera
reviewed
May 6, 2026
vkucera
reviewed
May 6, 2026
vkucera
reviewed
May 6, 2026
Collaborator
|
Error while checking build/O2Physics/staging for 5397abb at 2026-05-07 21:51: Full log here. |
Collaborator
Collaborator
Contributor
Author
|
Dear @vkucera, I am planning to update this PR this week, addressing your comments. |
Updated event selection configuration and histogram handling in zdcExtraTableReader.cxx. Refactored selection bits and improved memory management in the clearCache method.
Formatting changes to AliceO2Group#16028
vkucera
reviewed
Jun 4, 2026
- Replace 0.0 returns with fatal logs for missing CCDB objects - Rename Configurable flags - Rename 'nShift' to 'nHarmonics' to clarify its physical meaning - Remove 'm' prefixes from variable names - Reduce nesting in `loadCalibrations`
Fix code formatting
Contributor
Author
|
Dear code owners, Please note that the failed CI checks are not related to my zdc-extra-table-reader task:
|
Collaborator
|
@udmitrie Since you are adding a new file, please fix the warnings as well. |
Replaced individual Qx and Qy axis configurables with a shared ConfigurableAxis
Contributor
Author
|
Dear @vkucera, could you please confirm that you have no further comments? Otherwise, is there anything else I need to fix? |
vkucera
reviewed
Jun 9, 2026
| std::unordered_map<int, TProfile3D*> gShiftProfileZNA; | ||
| std::unordered_map<int, TProfile3D*> gShiftProfileZNC; | ||
|
|
||
| TH1* gCurrentEventCounter; |
Collaborator
There was a problem hiding this comment.
Pointers should always be initialised at declaration.
vkucera
reviewed
Jun 9, 2026
| calibCache.clear(); | ||
| } | ||
|
|
||
| void initHistos(const int& runNumber) |
Collaborator
There was a problem hiding this comment.
Pass small types by value.
Suggested change
| void initHistos(const int& runNumber) | |
| void initHistos(const int runNumber) |
vkucera
reviewed
Jun 9, 2026
| } | ||
|
|
||
| // Optimized method to load ALL calibrations for the new run at once | ||
| void loadCalibrations(int run) |
Collaborator
There was a problem hiding this comment.
Is run different from runNumber?
vkucera
reviewed
Jun 9, 2026
| if (applyShiftCorrection) { | ||
| std::string folder = Form("%s/psiHarm", qRecenteringCcdb.value.c_str()); | ||
|
|
||
| LOGF(info, "ZDC Analysis: Loading Shift Correction from %s for run %d", folder.c_str(), run); |
Collaborator
There was a problem hiding this comment.
Does this get printed for each collision?
Collaborator
|
Error while checking build/O2Physics/o2 for bf83055 at 2026-06-09 18:57: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zdc-extra-table-reader is needed to read AOD/ZDCEXTRA derived data and proceed with multi-step calibration (Q-vectors recentering) of ZDC data