[PWGHF] Update treeCreator for Xic0 -> Xi Pi#16583
Open
jinhyunni wants to merge 6 commits into
Open
Conversation
added 2 commits
June 9, 2026 17:09
jinhyunni
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#16583
vkucera
reviewed
Jun 9, 2026
| for (const auto& particle : mcParticles) { | ||
| fillParticle(particle, o2::constants::physics::MassXiC0); | ||
| } | ||
| fillParticle<MyEventTableWithMcLabels, aod::McCollisions>(mcParticles, collsWithMcLable); |
Collaborator
There was a problem hiding this comment.
Why do you need to provide CollType?
Contributor
Author
There was a problem hiding this comment.
Hi @vkucera, thanks for the review!
Can I ask more specifically what you mean by providing the CollType?
Do you mean that I don’t need to provide it within <> in this case?
Collaborator
There was a problem hiding this comment.
Yes, the type is deducible from the argument.
Contributor
Author
There was a problem hiding this comment.
I see your point. I've updated to pass template arguements as your advice.
Thanks for letting me know!
If everything seems okay with you, could you approve this PR and merge it?
vkucera
reviewed
Jun 9, 2026
vkucera
reviewed
Jun 9, 2026
added 2 commits
June 9, 2026 23:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to update tree creator for Xic0->Xi Pi workflow.
Additional information on generated particles will be stored to perform corrections to raw yields.
Also, new headerfile
PWGLF/DataModel/mcCentrality.hwas added to support multiplicity dependent studies with MC.