Can only have 1 resource review

Author: AllanKoder

app/Http/Controllers/ResourceReviewController.php

@@ -8,17 +8,29 @@
 use App\Models\ResourceReview;
 use Auth;
 use Illuminate\Support\Facades\Log;
+use Redirect;
 
 class ResourceReviewController extends Controller
 {
     // Store the review on the resource
     public function store(StoreResourceReview $request, ComputerScienceResource $computerScienceResource)
     {
-        Log::debug("Storing resource review: " . json_encode($request));
-
         // Validate the request data
         $validatedData = $request->validated();
 
+        $existingReview = ResourceReview::where([
+            'user_id' => Auth::id(),
+            'computer_science_resource_id' => $computerScienceResource->id,
+        ])->first();
+
+        if ($existingReview) {
+            Log::debug("User has already posted a review");
+            // TODO: Make it a json with errors instead
+            return back()->with('warning', 'You already have a review posted, you should edit your existing one instead.');
+        }
+
+        Log::debug("Storing resource review: " . json_encode($validatedData));
+
         // Create the resource review
         $review = ResourceReview::create([
             'user_id' => Auth::id(),
@@ -37,6 +49,7 @@ public function store(StoreResourceReview $request, ComputerScienceResource $com
 
         ResourceReviewProcessed::dispatch($computerScienceResource->id, null, $review->attributesToArray());
 
+        // Json with success
         return to_route('resources.show', ['computerScienceResource' => $review->computer_science_resource_id])
             ->with('success', 'Review created successfully!');
     }

database/factories/ResourceReviewFactory.php

@@ -20,11 +20,7 @@ class ResourceReviewFactory extends Factory
     public function definition(): array
     {
         return [
-            'user_id' => function () {
-                return User::inRandomOrder()->firstOr(function () {
-                    return User::factory()->create();
-                })->id;
-            },
+            'user_id' => User::factory()->create()->id, // Is creating a new user since we need users to be unique per review
             'computer_science_resource_id' => function () {
                 return ComputerScienceResource::firstOr(function () {
                     return ComputerScienceResource::factory()->create();

database/migrations/2025_02_14_225555_create_resource_reviews_table.php

@@ -17,6 +17,11 @@ public function up(): void
             $table->id();
             $table->foreignIdFor(User::class)->index();
             $table->foreignIdFor(ComputerScienceResource::class)->index();
+            
+            $table->unique([
+                'user_id',
+                'computer_science_resource_id'
+            ]);
 
             // Text
             $table->string('title');

tests/Feature/ResourceReviewsTest.php

@@ -67,18 +67,39 @@ public function test_resource_review_can_be_posted(): void
 
         $data = ResourceReviewTestResource::fake();
 
-        $response = $this->actingAs($user)
+        $this->actingAs($user)
             ->post(route('reviews.store', $resource), $data);
 
-        $response->assertRedirect(route('resources.show', ['computerScienceResource' => $resource->id]))
-                 ->assertSessionHas('success', 'Review created successfully!');
-
         $this->assertDatabaseHas('resource_reviews', [
             'computer_science_resource_id' => $resource->id,
             'title' => $data['title']
         ]);
     }
 
+    public function test_resource_review_cannot_be_posted_twice(): void
+    {
+        $user = User::factory()->create();
+        $resource = ComputerScienceResource::factory()->create();
+
+        $data1 = ResourceReviewTestResource::fake();
+        $this->actingAs($user)
+            ->post(route('reviews.store', $resource), $data1);
+
+        $this->assertDatabaseHas('resource_reviews', [
+            'computer_science_resource_id' => $resource->id,
+            'title' => $data1['title']
+        ]);
+
+        $data2 = ResourceReviewTestResource::fake();
+        $this->actingAs($user)
+            ->post(route('reviews.store', $resource), $data2);
+        
+        $this->assertDatabaseMissing('resource_reviews', [
+            'computer_science_resource_id' => $resource->id,
+            'title' => $data2['title']
+        ]);
+    }
+
     public function test_resource_average_has_changed(): void
     {
         $user = User::factory()->create();