From 4555fe17c5e7d3a8b71b3fb9b3a5412f4092b825 Mon Sep 17 00:00:00 2001 From: Laxman Reddy Aileni Date: Wed, 15 Jul 2026 00:55:58 +0000 Subject: [PATCH 1/2] fix: avoid redundant scrollbar in sheet (MCP view double scrollbar) The sheet body used overflow-y: scroll, which always renders a scrollbar even when the content fits. Combined with the inner scrollable list (e.g. the MCP view), this produced a second, redundant scrollbar wrapping the whole panel. Use overflow-y: auto so a scrollbar only appears when content actually overflows, for both the standard and fullscreen sheet. --- src/styles/components/_sheet.scss | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/styles/components/_sheet.scss b/src/styles/components/_sheet.scss index 970cd255f..f7954fae2 100644 --- a/src/styles/components/_sheet.scss +++ b/src/styles/components/_sheet.scss @@ -89,7 +89,9 @@ border-radius: 0; height: 100%; overflow-x: hidden; - overflow-y: scroll; + // Only show the scrollbar when content overflows, avoiding a permanent + // (often empty) scrollbar in the fullscreen sheet. + overflow-y: auto; } > .mynah-card-body { @@ -126,7 +128,11 @@ gap: var(--mynah-sizing-4); align-items: stretch; flex: 1; - overflow-y: scroll; + // Use auto so the scrollbar only appears when the content actually + // overflows. With 'scroll' the sheet body always renders a scrollbar, + // which combined with the inner scrollable list (e.g. the MCP view) + // produced a redundant second scrollbar wrapping the whole panel. + overflow-y: auto; overflow-x: hidden; > .mynah-sheet-header-status { box-shadow: none; From c43d398898b9ce3e0d55cf64d1047d1d4c771e88 Mon Sep 17 00:00:00 2001 From: Laxman Reddy Aileni Date: Wed, 15 Jul 2026 00:55:58 +0000 Subject: [PATCH 2/2] chore: coerce evaluate result to boolean in quick-action header flow Keeps the repo lint gate green (strict-boolean-expressions). --- ui-tests/__test__/flows/quick-action-commands-header.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui-tests/__test__/flows/quick-action-commands-header.ts b/ui-tests/__test__/flows/quick-action-commands-header.ts index c90e28b6f..a0e6c7ae8 100644 --- a/ui-tests/__test__/flows/quick-action-commands-header.ts +++ b/ui-tests/__test__/flows/quick-action-commands-header.ts @@ -137,9 +137,9 @@ export const verifyQuickActionCommandsHeaderStatusVariations = async (page: Page let foundStatusClass = false; for (const statusClass of statusClasses) { - const hasStatus = await headerElement.evaluate((el, className) => + const hasStatus = Boolean(await headerElement.evaluate((el, className) => el.classList.contains(className), statusClass - ); + )); if (hasStatus) { foundStatusClass = true; console.log(`Found status class: ${statusClass}`);