-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomerspythonPull requests that update Python codePull requests that update Python code
Description
When using the filesystem KVS, the , in the key strings are converted to - to remain as a valid filename. The all roster source fetches all available keys and extracts student ids by splitting on ,.
Even if students exist in the filesystem, their IDs are not being properly extracted and thus, we end up with an empty class.
We could:
- Warn the user that these are incompatible setting
- Create an edge case
learning_observer/rosters.py:all_studentsthat checks the KVS type and extracts students based on that - Modify the FileSystem KVS to use the appropriate key string when returning
.keys()
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomerspythonPull requests that update Python codePull requests that update Python code