Flag --max-surge in az aks nodepool upgrade has no effect

[lorenzo-biava]

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug

Flag --max-surge in az aks nodepool upgrade has no effect.
You need to issue a az aks nodepool update --max-surge=N before running the upgrade to actually be able to use the surge.

To Reproduce

Run this on an AKS nodepool and observe a single extra node gets created instead of 5:
az aks nodepool upgrade --max-surge 5

Expected behavior

The flag should perform the upgrade with the provided number of surge nodes.
At the very least, the flag should not be available if the only way (API-wise) is to run the update command first.

Environment summary

# az version
{
  "azure-cli": "2.28.0",
  "azure-cli-core": "2.28.0",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {
    "aks-preview": "0.5.34",
    "subscription": "0.1.4"
  }
}

AKS v1.20.9

Additional context

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/aks-pm.

Issue Details

---

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug

Flag --max-surge in az aks nodepool upgrade has no effect.
You need to issue a az aks nodepool update --max-surge=N before running the upgrade to actually be able to use the surge.

To Reproduce

Run this on an AKS nodepool and observe a single extra node gets created instead of 5:
az aks nodepool upgrade --max-surge 5

Expected behavior

The flag should perform the upgrade with the provided number of surge nodes.
At the very least, the flag should not be available if the only way (API-wide) is to run the update command first.

Environment summary

# az version
{
  "azure-cli": "2.28.0",
  "azure-cli-core": "2.28.0",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {
    "aks-preview": "0.5.34",
    "subscription": "0.1.4"
  }
}

AKS v1.20.9

Additional context

Author:	lorenzo-biava
Assignees:	-
Labels:	Service Attention, AKS, customer-reported
Milestone:	-

[yonzhan]

route to service team

[navba-MSFT]

@lorenzo-biava Apologies for the late reply. The parameter --max-surge is for the Extra nodes used to speed upgrade. AKS accepts both integer values and a percentage value for max surge. An integer such as "5" indicates five extra nodes to surge. A value of "50%" indicates a surge value of half the current node count in the pool. For production node pools, we recommend a max_surge setting of 33%.

The series of steps followed by the AKS during upgrade and the --max-surge checks is explained here. Hope this helps.

[lorenzo-biava]

@navba-MSFT Thanks for the explanation. However the gist of the issue is that you have such flag available in the az aks nodepool upgrade command, but it's not doing anything. You need to issue the update command first, and then run the upgrade.

My ask would be to fix the upgrade command to actually use the flag.