-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add short timeout to version check HTTP requests #24577
Copy link
Copy link
Open
Labels
Auto-AssignAuto assign by botAuto assign by botAzure CLI TeamThe command of the issue is owned by Azure CLI teamThe command of the issue is owned by Azure CLI teamComputeaz vm/vmss/image/disk/snapshotaz vm/vmss/image/disk/snapshotact-observability-squadcustomer-reportedIssues that are reported by GitHub users external to the Azure organization.Issues that are reported by GitHub users external to the Azure organization.feature-requestneeds-team-triageThis issue needs the team to triage.This issue needs the team to triage.
Milestone
Metadata
Metadata
Assignees
Labels
Auto-AssignAuto assign by botAuto assign by botAzure CLI TeamThe command of the issue is owned by Azure CLI teamThe command of the issue is owned by Azure CLI teamComputeaz vm/vmss/image/disk/snapshotaz vm/vmss/image/disk/snapshotact-observability-squadcustomer-reportedIssues that are reported by GitHub users external to the Azure organization.Issues that are reported by GitHub users external to the Azure organization.feature-requestneeds-team-triageThis issue needs the team to triage.This issue needs the team to triage.
Related command
az vmss reimage --debug --helpIs your feature request related to a problem? Please describe.
In case of low transfer speed to
raw.githubusercontent.com, commands with--helpargument hangs for a long time. This seem largely suspicious and unhelpful when dealing with--helpcommands.Describe the solution you'd like
IIUC this HTTP requests are related to checking version of CLI. If that's the case, I think those requests should have some fixed deadline/timeout which when hit, may produce a warning message. Taking general slowness of Azure CLI, perhaps timeout of 500-1000 ms should not be that bad, comparing to my which was 80 seconds.
Additional context