ACR self.cmd did not detect command failure

[nguyenm2151]

Describe the bug

ACR team uses the self.cmd command to confirm that our command successfully runs with no errors. However, we have noticed that our test using self.cmd still passes even though our acr agentpool delete command returns an error

azure-cli/src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_agentpool_commands.py

Line 67 in f92f723

self.cmd('acr agentpool delete -n {agents2_name} -r {registry_name} -y')

Related command

acr agentpool delete -n {agents2_name} -r {registry_name}

Errors

NA

Issue script & Debug output

NA

Expected behavior

Test fail when command returns an error message

Environment Summary

{ "auzre-cli": "2.67.0", "azure-cli-core": "2.67.0", "azure-cli-telemetry": "1.1.0", "extensions": { "acrtransfer": "1.1.0" } }

Additional context

No response

[yonzhan]

Thank you for opening this issue, we will look into it.

[microsoft-github-policy-service]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @toddysm, @luisdlp, @northtyphoon, @terencet-dev.

[toddysm]

@leodewang this is related to how we output error codes. We should look at this and create general guidelines.