Create Entities in-memory from Autoentities#3129
Open
RubenCerna2079 wants to merge 22 commits intomainfrom
Open
Create Entities in-memory from Autoentities#3129RubenCerna2079 wants to merge 22 commits intomainfrom
RubenCerna2079 wants to merge 22 commits intomainfrom
Conversation
RubenCerna2079
force-pushed
the
dev/rubencerna/create-inmemory-entities-from-autoentities
branch
from
1972a8f to
2f256e4
Compare
RubenCerna2079
requested review from
Alekhya-Polavarapu,
aaronburtle,
anushakolan,
neeraj-sharma2592,
sourabh1007,
souvikghosh04 and
vadeveka
as code owners
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
reviewed
Feb 13, 2026
Aniruddh25
reviewed
Feb 13, 2026
Aniruddh25
reviewed
Feb 13, 2026
Aniruddh25
reviewed
Feb 13, 2026
Aniruddh25
reviewed
Feb 13, 2026
Aniruddh25
approved these changes
Feb 13, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
JerryNixon
approved these changes
Feb 16, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
reviewed
Feb 20, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
reviewed
Feb 20, 2026
|
|
||
| _entityNameToDataSourceName = new Dictionary<string, string>(); | ||
| if (Entities is null) | ||
| if (Entities is null && this.Entities.Entities.Count == 0 && |
Collaborator
There was a problem hiding this comment.
This condition will throw NullException
Aniruddh25
reviewed
Feb 20, 2026
| { | ||
| foreach (KeyValuePair<string, Entity> entity in Entities) | ||
| { | ||
| _entityNameToDataSourceName.TryAdd(entity.Key, this.DefaultDataSourceName); |
Collaborator
There was a problem hiding this comment.
Why are we always adding to the default data source name here? Shouldnt we add it to the data source name found from the Datasource files? If there is no name found there, we should use default data source name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
We need to generate all the entities from the autoentities properties. In order to do this we need to use the query that was previously created and, add the newly generated entities into the runtime so the user can use them.
What is this change?
MsSqlMetadataProvider.cs: Finish creating theGenerateAutoentitiesIntoEntitiesfunction so that it uses the query to receive all of the tables and turn them into entities inside the runtimeConfig.RuntimeConfig.cs: Create new function that adds the new entities to the runtimeConfig. And also change the runtimeConfig to allow for theentitiesproperty to be missing if the user decides to use theautoentitiesproperty.How was this tested?