ci(aur): bump deploy-aur action v4.1.1 -> v4.1.3 (fix bash --command crash)#232
Conversation
…crash) v4.1.1 entrypoint.sh used `runuser builder --command` which crashes on current GitHub-hosted Ubuntu runners; v4.1.3 fixes the invocation. build.sh is byte-identical between v4.1.1 and v4.1.3, so #183/#184 fixes (force_push + post_process master branch) are fully preserved. Fix-forward path for the pending v0.5.5 AUR stable backfill.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
📝 WalkthroughWalkthroughThis PR updates the AUR publish workflow to use ChangesAUR Deploy Action Pin Upgrade
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
openspec/changes/2026-05-17-fix-aur-deploy-action-v413/proposal.md (1)
10-12: 💤 Low valueAdd language identifier to fenced code block.
Specify the language for better rendering and accessibility.
📝 Proposed fix
-``` +```text bash: --command: invalid option</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.In
@openspec/changes/2026-05-17-fix-aur-deploy-action-v413/proposal.mdaround
lines 10 - 12, The fenced code block in proposal.md lacks a language identifier;
update the triple-backtick fence that contains "bash: --command: invalid option"
to include a language tag (e.g.,text orbash) so the snippet renders
correctly and improves accessibility—locate the fenced block in the file and add
the chosen language after the opening backticks.</details> </blockquote></details> </blockquote></details> <details> <summary>🤖 Prompt for all review comments with AI agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.Nitpick comments:
In@openspec/changes/2026-05-17-fix-aur-deploy-action-v413/proposal.md:
- Around line 10-12: The fenced code block in proposal.md lacks a language
identifier; update the triple-backtick fence that contains "bash: --command:
invalid option" to include a language tag (e.g.,text orbash) so the
snippet renders correctly and improves accessibility—locate the fenced block in
the file and add the chosen language after the opening backticks.</details> --- <details> <summary>ℹ️ Review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro **Run ID**: `cdfa384a-d8e8-42f5-b91f-aeeb191c8aaa` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 1c37444d9c9cbbfcb89cdc85946eb485f8d16d7b and 7b6802badbc1858c43edf19b4dbae5f75b52ee37. </details> <details> <summary>📒 Files selected for processing (4)</summary> * `.github/workflows/aur.yml` * `openspec/changes/2026-05-17-fix-aur-deploy-action-v413/proposal.md` * `openspec/changes/2026-05-17-fix-aur-deploy-action-v413/tasks.md` * `openspec/changes/2026-05-17-fix-aur-deploy-action-v413/test-plan.md` </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Summary
Fix-forward: the
AUR Publishworkflow failed on the v0.5.5 tag (run 26001352704, jobPublish rdc-cli (stable)) withbash: --command: invalid option, before any AUR git operation.Root cause is in the pinned action itself, not our config:
KSXGitHub/github-actions-deploy-aurat v4.1.1 (2ac5a4c…) ends itsentrypoint.shwithexec runuser builder --command 'bash -l -c /build.sh'. With theutil-linuxrunuserin the currentarchlinux:baseimage this uses the su(1)-compatible form, so--command …is passed to bash as a flag — bash has no--command, it crashes before/build.shruns. Thepost_process: git checkout -B masterinput is never reached and is innocent. The workflow was green on earlier tags; a recent Arch base image surfaced this latent action bug (present v3.0.1–v4.1.1; upstream fixed it in v4.1.2/v4.1.3).Change
Bump both pins in
.github/workflows/aur.yml(jobsaur-git,aur-stable) from2ac5a4c… # v4.1.1toda03e160361ce01bf087e790b6ffd196d7dccff7 # v4.1.3.force_push: trueandpost_process: git checkout -B masterunchanged.gh api compare/v4.1.1...v4.1.3confirms onlyREADME.md+entrypoint.shchanged between the two tags —build.shis byte-identical, so the #183 (detached-HEAD →post_process) and #184 (force_push) fixes are fully preserved; only the entrypoint crash is fixed.Residual risk (inherent, monitor): the action is
using: dockerFROM archlinux:basewith no digest pin, so a future Arch base change could break it again regardless of action tag.After merge
v0.5.5 PyPI + GitHub Release already shipped; only the AUR package is outstanding. Once merged, the v0.5.5 AUR
rdc-clipackage is backfilled by runningAUR Publishviaworkflow_dispatchwithversion=0.5.5.OpenSpec:
openspec/changes/2026-05-17-fix-aur-deploy-action-v413/.Summary by CodeRabbit
Chores
Documentation