Skip to content

Webkit-68/ Bind input field to data row to reflect changes in form control modal #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trifiasco wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Webkit-68/ Bind input field to data row to reflect changes in form control modal #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f48de8
WebKit-68: Pass current input field instance in custom event post
trifiasco Nov 8, 2021
2c8b184
WebKit-68: Bind input field changes to data row in form-control
trifiasco Nov 8, 2021
9c8d31e
WebKit-68: Add demo form handling instructions
trifiasco Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions demo/ChileCompanyCustomerPortal/forms/ChileCompanyCustomerForm.bbj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ class public ChileCompanyCustomerForm extends BBjWidget
methodend

method public void onFormSubmit(BBjCustomEvent ev!)
REM we will get data row object with submitted form values in ev!.getObject()
REM Need to handle db operation here
ClientUtil.consoleLog(str(ev!.getObject()))
methodend

Expand Down
13 changes: 12 additions & 1 deletion framework/FormControlPanel/FormControlPanel.bbj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ class public FormControlPanel

method public void setResultSet(ResultSet rs!)
#RS! = rs!
#dataRow! = new DataRow(rs!)
Copy link
Copy Markdown
Collaborator

@StephanWald StephanWald Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does that mean - build a DataRow object from a ResultSet? Create a DataRow from a ResultSet?
Take the first record? What if the ResultSet is null() or empty?
It's unclear to me what is the dataRow! variable versus the ResultSet!in this class, maybe a few comments would do goo.

methodend

method public DataRow getResultSet()
Expand Down Expand Up @@ -99,9 +100,12 @@ class public FormControlPanel

columnName! = columnNames!.get(i)
_fieldLabel! = new InputField(fieldWnd!)
_fieldLabel!.setId(columnName!)
_inputField! = _fieldLabel!.getInputField()
_fieldLabel!.setCallback(InputField.ON_INPUT_CHANGE, #this!, "onInputChange")

if #isEdit! = 1 THEN
_fieldLabel!.getInputField().setText(str(#dataRow!.getFieldValue(columnName!)))
_inputField!.setText(str(#dataRow!.getFieldValue(columnName!)))
else
_fieldLabel!.setPlaceHolder(columnName!)
fi
Expand Down Expand Up @@ -137,6 +141,13 @@ class public FormControlPanel
#overlay!.setCallback(Overlay.ON_OVERLAY_DISSMISSED, #this!,"onOverlayDissmiss")
methodend

method public void onInputChange(BBjCustomEvent ev!)
obj! = ev!.getObject()
fieldId! = obj!.getId()
fieldValue! = obj!.getInput()
#dataRow!.setFieldValue(fieldId!, fieldValue!)
methodend

method public void onFormSubmit(BBjButtonPushEvent ev!)
#overlay!.onOverlayDissmiss(null())
BBjAPI().postCustomEvent("ON_FORM_SUBMIT", #dataRow!)
Expand Down
2 changes: 1 addition & 1 deletion widgets/InputField/InputField.bbj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ class public InputField extends BBjWidget implements Icon
endif
endif
endif
#fireEvent(#ON_INPUT_CHANGE, "")
#fireEvent(#ON_INPUT_CHANGE, #this!)
methodend

method public void focus()
Expand Down