Skip to content

Potential bug in evaluate_single_query #7

Description

@qlan3

If I understand it correctly, for the preprocess in function evaluate_single_query, we need to convert response and answer to the same type before comparing.
However, after checking Line 140-148, I notice that answer_df is converted to str first:

answer_df[col] = answer_df[col].astype(str)

But later it might be converted to float:
answer_df[col] = answer_df[col].astype(float)

while response_df is always converted to str:
response_df[col] = response_df[col].astype(str)

Is this a bug? If so, will it affect the final result greatly?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions