If I understand it correctly, for the preprocess in function evaluate_single_query, we need to convert response and answer to the same type before comparing.
However, after checking Line 140-148, I notice that answer_df is converted to str first:
|
answer_df[col] = answer_df[col].astype(str) |
But later it might be converted to float:
|
answer_df[col] = answer_df[col].astype(float) |
while
response_df is always converted to
str:
|
response_df[col] = response_df[col].astype(str) |
Is this a bug? If so, will it affect the final result greatly?
If I understand it correctly, for the preprocess in function
evaluate_single_query, we need to convert response and answer to the same type before comparing.However, after checking Line 140-148, I notice that
answer_dfis converted tostrfirst:WideSearch/src/evaluation/evaluation.py
Line 140 in 0e664c3
But later it might be converted to float:
WideSearch/src/evaluation/evaluation.py
Line 147 in 0e664c3
while
response_dfis always converted tostr:WideSearch/src/evaluation/evaluation.py
Line 148 in 0e664c3
Is this a bug? If so, will it affect the final result greatly?