minor issue with LYD_PARSE_LYB_SKIP_CTX_CHECK

[rcasellas]

Hi all

There seems to be a change in a libyang enum so and app using libyang-cpp does not compile

I am getting

src/ext/libyang-cpp/src/utils/enum.hpp:224:64: error: ‘LYD_PARSE_LYB_SKIP_CTX_CHECK’ was not declared in this scope; did you mean ‘LYD_PARSE_LYB_SKIP_MODULE_CHECK’?

I am using:

FetchContent_Declare(libyang
GIT_REPOSITORY https://github.com/CESNET/libyang.git
GIT_TAG devel # libyang-cpp requires devel (v4+)
)

using libyang-cpp as a submodule

ext/libyang-cpp$ git status
HEAD detached at 1fd11bd
nothing to commit, working tree clean

Thanks in advance

Ramon

[jktjkt]

Our README says that libyang-cpp currently requires libyang 4.2+ (and has been so since commit 38d5c10 two months ago). There are additional breaking changes which the upstream introduced in libyang 4.5/4.6, and these changes require an extra patch (a449179). We have not merged that patch just yet because we're seeing multiple regressions throughout the stack -- both via test suites of various projects, public and in-house, and also in the user-facing string serialization of some YANG types due to RFC 9911.

I see that there's also been a CESNET/libyang@a4e7326 which landed earlier today, and which renamed the typedef LYD_PARSE_LYB_SKIP_CTX_CHECK. I don't know whether @michalvasko and @Roytak realized that this is yet another change which breaks the build for downstream consumers. We will adapt to that, as usual, but in the meanwhile, I suggest to stick with, e.g., CESNET/libyang@0eda18938 (aka version 4.3.8) which is the last version prior to the most recent big changes.

[jktjkt]

This patch will build against the most recent devel of libyang -- but beware, there are regressions e.g. in libnetconf2. An (incomplete) list of other changes which are required is at https://gerrit.cesnet.cz/q/topic:update-yang+is:open . In the meanwhile, I've pushed a README and CI update which pins the deps to libyang < 4.4.

[rcasellas]

Hi

Thanks for the fast response :) quite unfortunate that I just came back from a two month leave :) and missed your points (just compiled two months and half ago)

Sorry for the noise
R

[jktjkt]

No need to apologize, this is expected to work. Bad timing indeed :).