From 5294f3c1743ba5f4d736b92d3204800506922269 Mon Sep 17 00:00:00 2001 From: Katie Breivik Date: Tue, 2 Jun 2026 11:45:55 -0400 Subject: [PATCH 1/3] tiny fix to ran3 definition as real rather than real*8 --- src/cosmic/src/assign_remnant.f | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/cosmic/src/assign_remnant.f b/src/cosmic/src/assign_remnant.f index 35d32202d..3c2b099ea 100644 --- a/src/cosmic/src/assign_remnant.f +++ b/src/cosmic/src/assign_remnant.f @@ -712,9 +712,11 @@ SUBROUTINE assign_remnant_spin(mc, bhspin) IMPLICIT NONE INCLUDE 'const_bse.h' - real*8 ran3, mc, bhspin + real ran3 EXTERNAL ran3 + real*8 mc, bhspin + * Set all BH spins equal to bhspinmag if(bhspinflag.eq.0)then bhspin = bhspinmag @@ -732,6 +734,8 @@ SUBROUTINE assign_remnant_spin(mc, bhspin) endif endif + WRITE(*,*) 'Assigned BH spin = ', bhspin + end integer function first_mt_type_as_donor(star) From 6d048d941f877b95c9bd4ebd55502d0625e98881 Mon Sep 17 00:00:00 2001 From: Katie Breivik Date: Tue, 2 Jun 2026 11:50:52 -0400 Subject: [PATCH 2/3] remove egregious write debugging --- src/cosmic/src/assign_remnant.f | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/cosmic/src/assign_remnant.f b/src/cosmic/src/assign_remnant.f index 3c2b099ea..f3f681cd0 100644 --- a/src/cosmic/src/assign_remnant.f +++ b/src/cosmic/src/assign_remnant.f @@ -733,9 +733,7 @@ SUBROUTINE assign_remnant_spin(mc, bhspin) bhspin = 0.0d0 endif endif - - WRITE(*,*) 'Assigned BH spin = ', bhspin - + end integer function first_mt_type_as_donor(star) From d315d1769ce29899a62a033d4fc1379d8aec0ca0 Mon Sep 17 00:00:00 2001 From: Katie Breivik Date: Tue, 2 Jun 2026 12:04:56 -0400 Subject: [PATCH 3/3] update changelog --- changelog.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/changelog.md b/changelog.md index 5fa722f81..d93272527 100644 --- a/changelog.md +++ b/changelog.md @@ -10,7 +10,9 @@ - Function signature for kick() and evolv2() in the fortran changed to remove ``bkick`` entirely - Also removed ``kick_info_out``. Both of these can be reconstructed from ``kick_info`` -- Bug fixes: corrected mass sign in bjorklund wind routine in SSE_mlwind.f +- Bug fixes: c + - corrected mass sign in bjorklund wind routine in SSE_mlwind.f + - fixed bug in ``bhspinmag`` assignment in ``assign_remnant.f`` ## 4.0.1