Description
Add tests demonstrating receive_payment does not invoke token transfers; document the threat-model note for ops.
Requirements and context
- Prevents confusion with real settlement.
- Align with
SECURITY.md external call checklist.
Suggested execution
- Fork the repo and create a branch:
git checkout -b test/revenue-pool-receive-payment-security
- Implement changes in the Callora-Contracts Soroban workspace (
contracts/*/src/).
- Run
cargo fmt, cargo clippy --all-targets --all-features -- -D warnings, and cargo test from the workspace root.
- For WASM release builds:
cargo build --target wasm32-unknown-unknown --release -p callora-revenue-pool (adjust -p if the crate name differs).
Deliverables
Test and commit
- Run tests and
./scripts/coverage.sh (or cargo tarpaulin per tarpaulin.toml).
- Cover edge cases; include summarized test output and brief security notes in the PR description.
Example commit message
test(revenue-pool): receive_payment does not transfer tokens
Guidelines
- Minimum 95% line coverage for touched crates (workspace policy).
- Clear documentation (Rust
/// on public items where applicable; repo markdown as needed).
- Timeframe: 96 hours from assignment unless agreed otherwise.
Description
Add tests demonstrating
receive_paymentdoes not invoke token transfers; document the threat-model note for ops.Requirements and context
SECURITY.mdexternal call checklist.Suggested execution
git checkout -b test/revenue-pool-receive-payment-securitycontracts/*/src/).cargo fmt,cargo clippy --all-targets --all-features -- -D warnings, andcargo testfrom the workspace root.cargo build --target wasm32-unknown-unknown --release -p callora-revenue-pool(adjust-pif the crate name differs).Deliverables
test.rs+ rustdoc.Test and commit
./scripts/coverage.sh(orcargo tarpaulinpertarpaulin.toml).Example commit message
Guidelines
///on public items where applicable; repo markdown as needed).