[HIGH] processRewardClaim retry path doesn't validate passing score

[DeFiVC]

Description

processRewardClaim in src/modules/rewards/reward.service.ts:27-80 doesn't check that the score meets the passing threshold. It uses the score parameter directly from the retry job without validating that the quiz was actually passed.

If the retry queue receives a job for a non-passing submission (e.g., due to a bug or manual queue manipulation), the reward will be processed.

Impact

Bypass of the passing requirement for reward claims via the retry path.

File

src/modules/rewards/reward.service.ts:27-80

Suggested Fix

Add a check that score >= passing threshold (70%) before processing the reward claim in the retry path.

[Clement-coder]

Hello, I'm a Full Stack Blockchain, Mobile, and Software Engineer with experience building scalable applications, smart contracts, APIs, and modern user-focused products.

I've reviewed this issue and understand the requirements and expected outcome. My background allows me to quickly analyze problems, implement efficient solutions, and maintain high code quality throughout development. I'm confident in my ability to deliver a clean, well-tested, and maintainable solution, and I'd be excited to contribute to this project.

[CleanDev-Fix]

Hi, I would like to work on this.

My planned approach:

1. Review the existing CI/test workflow path and keep the change scoped to the issue request.
2. Implement the smallest focused change needed for CI/test workflow without broad refactors.
3. Verify with the relevant build/test commands and the workflow syntax checks available locally and include the results in the PR.

One trade-off I will keep in mind: I will avoid expanding the scope beyond this issue unless you prefer a broader fix.

Does this approach line up with what you want for this issue?

[Danielodingz]

Hey Maintainer, please i would like to work on this issue.

[Menjay7]

Hi! I came across this issue and would love to work on it. I have experience with similar tasks and I'm confident I can investigate, implement a clean solution, and thoroughly test it before submitting a PR. If the issue is still open, I would appreciate it if you could assign it to me. Thank you!

[9904099]

This retry-path case is covered by PR #44:

#44

The PR updates both paths:

• claimReward now checks the quiz question count and requires the same 70% passing threshold before proof creation or any Stellar call.
• processRewardClaim now re-checks the queued retry job against the same threshold and skips non-passing submissions instead of processing the raw score.

Relevant validation is included there, especially tests/unit/services/reward-passing-threshold.test.ts, which covers below-threshold submissions and passing submissions.

[grantfox-oss]

🦊 GrantFox — @Danielodingz has been assigned to this issue as part of the Official Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #31)
2. Your PR will be reviewed by the ChainLearnOfficial maintainers

Good luck! Track your progress on GrantFox.