This package does some type-piracy on `Distributed.addprocs` and some `Base` types

[DilumAluthge]

I noticed that this package does some type-piracy. Here are the two methods that I noticed.

The first method is the Distributed.addprocs(::AbstractString, ::Int; kwargs...) method. The AzManagers.jl package does not own the function (Distributed.addprocs) or either of the types (Base.AbstractString or Base.Int). (Keyword arguments do not participate in method dispatch.)

AzManagers.jl/src/AzManagers.jl

Line 866 in a07e78c

function Distributed.addprocs(template::AbstractString, n::Int; kwargs...)

The second method is the Distributed.addprocs(::Dict, ::Int; kwargs...) method. The AzManagers.jl package does not own the function (Distributed.addprocs) or either of the types (Base.Dict or Base.Int).

AzManagers.jl/src/AzManagers.jl

Line 797 in a07e78c

function Distributed.addprocs(template::Dict, n::Int;

This is not ideal.

There are a couple of ways to fix this. Probably the easiest would be to have a new function named AzManagers.addprocs_azure, and then the two above methods would become methods of the AzManagers.addprocs_azure function (instead of the Distributed.addprocs function).

[jkurash]

This will be addressed in the upcoming v4.0 release. Tracking in PR #188.