[client-v2] Add support for custom socket factory options

[mayankvadariya]

Describe your feedback

Old client supports CUSTOM_SOCKET_FACTORY and CUSTOM_SOCKET_FACTORY_OPTIONS client options.

clickhouse-java/clickhouse-client/src/main/java/com/clickhouse/client/config/ClickHouseClientOption.java

Lines 40 to 47 in 25af97d

	CUSTOM_SOCKET_FACTORY("custom_socket_factory", "",
	"Full qualified class name of custom socket factory. This is only supported by TCP client and Apache Http Client."),
	/**
	* Additional socket factory options. Only useful only when
	* {@link #CUSTOM_SOCKET_FACTORY} is set.
	*/
	CUSTOM_SOCKET_FACTORY_OPTIONS("custom_socket_factory_options", "",
	"Comma separated options for custom socket factory."),

However, V2 doesn't support such options. Can we please add such options in V2? https://github.com/ClickHouse/clickhouse-java/blob/25af97d2d0f3dddbed8251216673d3135ce5d945/client-v2/src/main/java/com/clickhouse/client/api/ClientConfigProperties.java

[mayankvadariya]

@mzitnik @chernser @Paultagoras please advise if this issue is this considered as a bug in v2?

[chernser]

Good day, @mayankvadariya !
This is not a bug. One of the reason we dropped this configuration parameter because it is internal implementation details. Besides it may be not applicable for other clients.
Please tell us what is your use case and what configuration do you pass to a socket factory?

Thanks!

[mayankvadariya]

hi @chernser, thank you so much for looking into this issue. Most of the popular JDBC drivers such as mysql, postgresql, redshift and many other systems already supports custom SocketFactory implementations, allowing for enhanced security and custom network configurations. Our use case is pretty much along the same lines i.e to enforce stronger security measures, such as custom SSL/TLS configurations. Our application also needs add detailed logging of socket connection along with customizing some of the other network configuration. Initially this feature was implemented through #1391 in v1 but there is no such alternative with v2.

[chernser]

Good day, @mayankvadariya!
I see.

I've looked into the old PR and seems not much missing in client v2.
What SSL/TLS configuration would you like to set?
What do you usually log for sockets? Would it be useful to make a default client feature?

I think we can implement it by accepting reference to a socket factory. So no custom factory options as the factory will be configured on application side.
WDYT?

[mayankvadariya]

👋 hey @chernser! We would like to set custom options while creating a connection that needs available to the injected socketfactory. Agree with you that not providing custom options should be fine as far as the properties passed while calling the driver.connect(...)(or DriverManager.getConnection) are passed over while creating a custom socketfactory ie made available to socketfactory instance. If I remember correctly in V1, unknown properties are filtered initially and hence are not available until the point that the custom socketfactory was created and hence custom options was added to whitelist the unknown properties to ClickHouse drivers.

[chernser]

Thank you! I will discuss this feature with the team.

[mayankvadariya]

hi @chernser 👋! please advise any tentative timeline on the fix for this issue? so that we could upgrade to v2.

[chernser]

Good day, @mayankvadariya !
I may not provide exact dates about the timeline but this task in our focus. What we want to do it to make a configurable transport layer that should solve custom socket factory method.
Btw, we are going to add (there is a PR) to configure SNI.
If there are not many settings you'd like to set please list them and we might add them just a configuration like socket receive/send buffer size.

Thanks!