Replace unmaintained lz4-java with Apache Commons Compress LZ4

[laurentpellegrino]

org.lz4:lz4-java (1.8.0) has been unmaintained for years and triggers JDK 17 + startup warnings:

WARNING: A restricted method in java.lang.System has been called
WARNING: java.lang.System::loadLibrary has been called by net.jpountz.util.Native in an unnamed module (file:/home/X/.gradle/caches/modules-2/files-2.1/org.lz4/lz4-java/1.8.0/4b986a99445e49ea5fbf5d149c4b63f6ed6c6780/lz4-java-1.8.0.jar)
WARNING: Use --enable-native-access=ALL-UNNAMED to avoid a warning for callers in this module
WARNING: Restricted methods will be blocked in a future release unless native access is enabled

This native-loading path can also hurt performance.

Proposed fix

• Drop org.lz4:lz4-java.
• Add org.apache.commons:commons-compress (current release).
• Switch to its LZ4 APIs (org.apache.commons.compress.compressors.lz4.*).

Apache Commons Compress is actively maintained and JDK-compatible:
https://commons.apache.org/proper/commons-compress/apidocs/org/apache/commons/compress/compressors/lz4/package-summary.html

[chernser]

@laurentpellegrino thank you for pointing out!
What dependencies of java client do you use?

[chernser]

@laurentpellegrino
Currently we may not easily switch the compressor as it is very tight coupled with transport code.
We are using org.lz4 because it provides JNI version of the LZ4 what we would like to keep as an option.

So we will keep this change for later may be this year.

[linghengqian]

I'm not sure about the answer to #2126 . But if the minimum JDK runtime for the ClickHouse JDK driver is JDK 11, why not modularize the relevant code with JPMS? Using ALL-UNNAMED for --enable-native-access makes it hard to see how this is relevant to ClickHouse JDBC Driver.

[chernser]

Good day, @linghengqian !

Unfortunately we have to keep JDK 8 for a while :-(
However we are discussing is it better to move codebase on min 11 or even 17.

[linghengqian]

The changelog for https://github.com/ClickHouse/clickhouse-java/releases/tag/v0.9.8 appears to indicate that the ClickHouse Java client is using https://github.com/yawkat/lz4-java , which is actively maintained on the git repository.

Should this issue remain open?

[chernser]

Good day, @linghengqian!

I keep this issue open because I have not fully investigate the issue.