adopt more misc feedback.

ben-p-commits · ben-p-commits · commit fb9a969826bd · 2023-01-13T13:54:46.000-05:00
diff --git a/CodeEdit/Features/AppPreferences/Sections/TextEditingPreferences/TextEditingPreferencesView.swift b/CodeEdit/Features/AppPreferences/Sections/TextEditingPreferences/TextEditingPreferencesView.swift
@@ -51,8 +51,8 @@ struct TextEditingPreferencesView: View {
             PreferencesSection("Font") {
                 fontSelector
             }
-            PreferencesSection("Line Height Multiple") {
-                lineHeightMultiple
+            PreferencesSection("Line Height") {
+                lineHeight
             }
             PreferencesSection("Code completion") {
                 autocompleteBraces
@@ -102,12 +102,12 @@ struct TextEditingPreferencesView: View {
         }
     }
 
-    private var lineHeightMultiple: some View {
+    private var lineHeight: some View {
         HStack(spacing: 5) {
             TextField("", value: $prefs.preferences.textEditing.lineHeightMultiple, formatter: lineHeightFormatter)
                 .multilineTextAlignment(.trailing)
                 .frame(width: 40)
-            Stepper("Line Height Multiple:",
+            Stepper("Line Height:",
                     value: $prefs.preferences.textEditing.lineHeightMultiple,
                     in: 0.75...2.0,
                     step: 0.05)

Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,8 @@ struct TextEditingPreferencesView: View {`
`51`	`51`	`PreferencesSection("Font") {`
`52`	`52`	`fontSelector`
`53`	`53`	`}`
`54`		`- PreferencesSection("Line Height Multiple") {`
`55`		`- lineHeightMultiple`
	`54`	`+ PreferencesSection("Line Height") {`
	`55`	`+ lineHeight`
`56`	`56`	`}`
`57`	`57`	`PreferencesSection("Code completion") {`
`58`	`58`	`autocompleteBraces`
`@@ -102,12 +102,12 @@ struct TextEditingPreferencesView: View {`
`102`	`102`	`}`
`103`	`103`	`}`
`104`	`104`
`105`		`- private var lineHeightMultiple: some View {`
	`105`	`+ private var lineHeight: some View {`
`106`	`106`	`HStack(spacing: 5) {`
`107`	`107`	`TextField("", value: $prefs.preferences.textEditing.lineHeightMultiple, formatter: lineHeightFormatter)`
`108`	`108`	`.multilineTextAlignment(.trailing)`
`109`	`109`	`.frame(width: 40)`
`110`		`- Stepper("Line Height Multiple:",`
	`110`	`+ Stepper("Line Height:",`
`111`	`111`	`value: $prefs.preferences.textEditing.lineHeightMultiple,`
`112`	`112`	`in: 0.75...2.0,`
`113`	`113`	`step: 0.05)`