Skip to content

Commit a3c3784

Browse files
Merge branch 'main' into Wireframe-to-code-for-beginer-guide-20206
2 parents 49211c4 + 329eea0 commit a3c3784

8 files changed

Lines changed: 16 additions & 200 deletions

File tree

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 0 additions & 14 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/pd-assignment.yml

Lines changed: 0 additions & 59 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/tech-ed-assignment.yml

Lines changed: 0 additions & 88 deletions
This file was deleted.

.github/pull_request_template.md

Lines changed: 0 additions & 36 deletions
This file was deleted.

.github/workflows/validate-pr-metadata.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,5 @@ jobs:
1515
- uses: actions/checkout@v4
1616
- uses: CodeYourFuture/actions/validate-pr-metadata@main
1717
with:
18+
give_more_specific_comment_for_earlier_learners: true
1819
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Form-Controls/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ Do not write a form action for this project.
3030

3131
Let's write out our testable criteria. Check each one off as you complete it.
3232

33-
- [ ] I have used HTML only.
34-
- [x] I have not used any CSS or JavaScript.
33+
- [ ] I have only used HTML and CSS.
34+
- [ ] I have not used any JavaScript.
3535

3636
### HTML
3737

Form-Controls/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ <h1>Product Pick</h1>
2121
</main>
2222
<footer>
2323
<!-- change to your name-->
24-
<h2>By HOMEWORK SOLUTION</h2>
24+
<p>By HOMEWORK SOLUTION</p>
2525
</footer>
2626
</body>
2727
</html>

Wireframe/README.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@ There are some provided HTML and CSS files you can use to get started. You can u
1919
- [x] Check a webpage against a wireframe layout
2020
- [x] Test web code using [Lighthouse](https://programming.codeyourfuture.io/guides/testing/lighthouse)
2121
- [x] Use version control by committing often and pushing regularly to GitHub
22+
- [ ] Use semantic HTML tags to structure the webpage
23+
- [ ] Create three articles, each including an image, title, summary, and a link
24+
- [ ] Check a webpage against a wireframe layout
25+
- [ ] Test web code using [Lighthouse](https://programming.codeyourfuture.io/guides/testing/lighthouse)
26+
- [ ] Use version control by committing often and pushing regularly to GitHub
2227
<!--{{</objectives>}}>-->
2328

2429
## Acceptance Criteria
@@ -30,6 +35,13 @@ There are some provided HTML and CSS files you can use to get started. You can u
3035
- [x] The page footer is fixed to the bottom of the viewport.
3136
- [x] The webpage is styled using a linked .css file.
3237
- [x] The webpage is properly committed and pushed to a branch on GitHub.
38+
- [ ] Semantic HTML tags are used to structure the webpage.
39+
- [ ] The page scores 100 for Accessibility in the Lighthouse audit.
40+
- [ ] The page header includes a title and description.
41+
- [ ] The articles section has three unique articles, each including an image, title, summary, and a link.
42+
- [ ] The page footer is fixed to the bottom of the viewport.
43+
- [ ] The webpage is styled using a linked .css file.
44+
- [ ] The webpage is properly committed and pushed to a branch on GitHub.
3345

3446
## Resources
3547

0 commit comments

Comments
 (0)