Skip to content

Commit d4a600f

Browse files
authored
Merge branch 'main' into Staging-branch
2 parents 29ebd82 + ff7b9d0 commit d4a600f

11 files changed

Lines changed: 136 additions & 296 deletions

File tree

.github/FUNDING.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,2 @@
1-
# These are supported funding model platforms
2-
31
github: CodeYourFuture
4-
patreon: # Replace with a single Patreon username
5-
open_collective: # Replace with a single Open Collective username
6-
ko_fi: # Replace with a single Ko-fi username
7-
tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
8-
community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
9-
liberapay: # Replace with a single Liberapay username
10-
issuehunt: # Replace with a single IssueHunt username
11-
otechie: # Replace with a single Otechie username
12-
lfx_crowdfunding: # Replace with a single LFX Crowdfunding project-name e.g., cloud-foundry
132
custom: https://codeyourfuture.io/donate

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 0 additions & 14 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/pd-assignment.yml

Lines changed: 0 additions & 59 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/tech-ed-assignment.yml

Lines changed: 0 additions & 88 deletions
This file was deleted.

.github/pull_request_template.md

Lines changed: 0 additions & 32 deletions
This file was deleted.
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
name: Validate PR Metadata
2+
on:
3+
pull_request_target:
4+
types:
5+
- labeled
6+
- unlabeled
7+
- opened
8+
- edited
9+
- reopened
10+
11+
jobs:
12+
validate_pr_metadata:
13+
runs-on: ubuntu-latest
14+
steps:
15+
- uses: actions/checkout@v4
16+
- uses: CodeYourFuture/actions/validate-pr-metadata@main
17+
with:
18+
give_more_specific_comment_for_earlier_learners: true
19+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Form-Controls/README.md

Lines changed: 27 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,44 +8,60 @@
88
- [ ] Write a valid form
99
- [ ] Test with Devtools
1010
- [ ] Refactor using Devtools
11+
- [ ] Use version control by committing often and pushing regularly to GitHub
12+
- [ ] Develop the habit of writing clean, well-structured, and error-free code
1113
<!--{{<objectives>}}>-->
1214

1315
## Task
1416

15-
We are selling t-shirts. Write a form to collect the following data:
17+
We are selling T-shirts. Write a form to collect the following data:
1618

1719
Our customers already have accounts, so we know their addresses and charging details already. We don't need to collect that data. We want to confirm they are the right person, then get them to choose a colour and size.
1820

1921
Writing that out as a series of questions to ask yourself:
2022

21-
1. What is the customer's name? I must collect this data, and validate it. But what is a valid name? I must decide something.
22-
2. What is the customer's email? I must make sure the email is valid. Email addresses have a consistent pattern.
23-
3. What colour should this t-shirt be? I must give 3 options. How will I make sure they don't pick other colours?
24-
4. What size does the customer want? I must give the following 6 options: XS, S, M, L, XL, XXL
23+
1. What is the customer's name? I must collect this data and ensure it contains at least two non-space characters.
24+
2. What is the customer's email? I must make sure the email is valid. Email addresses follow a consistent pattern.
25+
3. What colour should this T-shirt be? I must provide 3 options. How will I ensure they do not choose other colours?
26+
4. What size does the customer want? I must provide the following 6 options: XS, S, M, L, XL, XXL
2527

2628
All fields are required.
2729
Do not write a form action for this project.
2830

29-
## Developers must test their work.
31+
## Acceptance Criteria
32+
33+
### Developers must test their work.
3034

3135
Let's write out our testable criteria. Check each one off as you complete it.
3236

33-
- [ ] I have used HTML only.
34-
- [x] I have not used any CSS or JavaScript.
37+
- [ ] I have only used HTML and CSS.
38+
- [ ] I have not used any JavaScript.
3539

3640
### HTML
3741

38-
- [ ] My form is semantic html.
42+
- [ ] My form is semantic HTML.
3943
- [ ] All inputs have associated labels.
4044
- [ ] My Lighthouse Accessibility score is 100.
41-
- [ ] I require a valid name. I have defined a valid name as a text string of two characters or more.
45+
- [ ] I require a valid name.
4246
- [ ] I require a valid email.
4347
- [ ] I require one colour from a defined set of 3 colours.
4448
- [ ] I require one size from a defined set of 6 sizes.
4549

46-
## Resources
50+
### Developers must adhere to professional standards.
51+
52+
> Before you say you're done: Is your code readable? Does it run correctly? Does it look professional?
4753
54+
These practices reflect the level of quality expected in professional work.
55+
They ensure your code is reliable, maintainable, and presents a polished, credible experience to users.
56+
57+
- [ ] My HTML code has no errors or warnings when validated using https://validator.w3.org/
58+
- [ ] My code is consistently formatted
59+
- [ ] My page content is free of typos and grammatical mistakes
60+
- [ ] I commit often and push regularly to GitHub
61+
62+
## Resources
4863
- [MDN: Form controls](https://developer.mozilla.org/en-US/docs/Learn/Forms)
4964
- [MDN: Form validation](https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation)
5065
- [Lighthouse](https://developers.google.com/web/tools/lighthouse)
5166
- [Lighthouse Guide](https://programming.codeyourfuture.io/guides/testing/lighthouse)
67+
- [Format Code and Make Logical Commits in VS Code](../practical_guide.md)

Form-Controls/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,4 +99,4 @@ <H1>Checking Form:</H1>
9999
</form>
100100
</main>
101101

102-
</html>
102+
</html>

HOW_TO_REVIEW.md

Lines changed: 0 additions & 66 deletions
This file was deleted.

0 commit comments

Comments
 (0)