Use getProviderApiKey helper for API key access

Author: avianion

web/src/llm-api/avian.ts

@@ -2,11 +2,11 @@ import { Agent } from 'undici'
 
 import { PROFIT_MARGIN } from '@codebuff/common/constants/limits'
 import { getErrorObject } from '@codebuff/common/util/error'
-import { env } from '@codebuff/internal/env'
 
 import {
   consumeCreditsForMessage,
   extractRequestMetadata,
+  getProviderApiKey,
   insertMessageToBigQuery,
 } from './helpers'
 
@@ -83,14 +83,12 @@ function createAvianRequest(params: {
     avianBody.stream_options = { include_usage: true }
   }
 
-  if (!env.AVIAN_API_KEY) {
-    throw new Error('AVIAN_API_KEY is not configured')
-  }
+  const apiKey = getProviderApiKey('AVIAN_API_KEY')
 
   return fetch(`${AVIAN_BASE_URL}/chat/completions`, {
     method: 'POST',
     headers: {
-      Authorization: `Bearer ${env.AVIAN_API_KEY}`,
+      Authorization: `Bearer ${apiKey}`,
       'Content-Type': 'application/json',
       'x-session-affinity': sessionId,
     },

web/src/llm-api/helpers.ts

@@ -6,12 +6,30 @@ import {
   isFreeModeAllowedAgentModel,
 } from '@codebuff/common/constants/free-agents'
 import { PROFIT_MARGIN } from '@codebuff/common/old-constants'
+import { env } from '@codebuff/internal/env'
 
+import type { ServerEnv } from '@codebuff/internal/env-schema'
 import type { InsertMessageBigqueryFn } from '@codebuff/common/types/contracts/bigquery'
 import type { Logger } from '@codebuff/common/types/contracts/logger'
 
 import type { ChatCompletionRequestBody } from './types'
 
+/** Known provider API key names in the env schema. */
+type ProviderApiKeyName = Extract<keyof ServerEnv, `${string}_API_KEY`>
+
+/**
+ * Retrieve a provider API key from the validated env, throwing a clear error
+ * if the key is missing or empty. Centralises the "is it configured?" check
+ * so individual provider modules don't need to guard against undefined.
+ */
+export function getProviderApiKey(name: ProviderApiKeyName): string {
+  const value = env[name]
+  if (!value) {
+    throw new Error(`${name} is not configured`)
+  }
+  return value
+}
+
 export type UsageData = {
   inputTokens: number
   outputTokens: number