Error after update to 3.7.0

[dmamchyts]

After update:

/var/www/html $ composer update

Loading composer repositories with package information
Restricting packages listed in "symfony/symfony" to "7.3.*"
Updating dependencies
Lock file operations: 0 installs, 1 updates, 0 removals
  - Upgrading codeception/module-symfony (3.6.0 => 3.7.0)

I got an error:

  [Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException] You have requested a non-existent service "profiler". Did you mean one of these: "web_profiler.controller.exception_panel", "web_profiler.controller.profiler", "web_profiler.controller.router"?  

[dmamchyts]

looks like related to #212

[mcop1]

We are encountering the same problem, looks like this change introduced it:

https://github.com/Codeception/module-symfony/pull/213/files#diff-b9ce0d13bb1001256fa498ed6cc44ee1aa6d08cf5dae99709cbabb9a9694d5bfR106

container->get() method throws an exception if the service wasn't found.

[TavoNiievez]

@mcop1 Indeed, removing the container->has() check was a mistake, and it went unnoticed in both the code review and our tests, as it seems that the profiler is always available there.

This PR should fix it: #216

This does not fix #212.

However, I am curious to know in which scenarios this module is used without the profiler available, since it is widely used for the vast majority of assertions not inherited from Symfony.

[TavoNiievez]

Released as 3.7.1

@dmamchyts Thanks for reporting!

[dmamchyts]

thanks for the quick solution

[mcop1]

@mcop1 Indeed, removing the container->has() check was a mistake, and it went unnoticed in both the code review and our tests, as it seems that the profiler is always available there.

This PR should fix it: #216

This does not fix #212.

However, I am curious to know in which scenarios this module is used without the profiler available, since it is widely used for the vast majority of assertions not inherited from Symfony.

Thanks for quick fix, really appreciated.

Right now, we are using it for running automated tests in a scheduled github workflow, so basically in a CLI environment. There we do a mix of functional and integration tests, where we mostly care if a test fails or not.