Skip to content

Commit 07f1fe5

Browse files
committed
Fixing ExitWithError action
1 parent 2d23644 commit 07f1fe5

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

render_machine/actions/exit_with_error.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
from plain2code_console import console
44
from render_machine.actions.base_action import BaseAction
55
from render_machine.render_context import RenderContext
6+
from render_machine.render_types import RenderError
67

78

89
class ExitWithError(BaseAction):
@@ -24,4 +25,9 @@ def execute(self, render_context: RenderContext, previous_action_payload: Any |
2425
if render_context.run_state.render_id is not None:
2526
console.info(f"Render ID: {render_context.run_state.render_id}")
2627

27-
return self.SUCCESSFUL_OUTCOME, previous_action_payload
28+
return (
29+
self.SUCCESSFUL_OUTCOME,
30+
RenderError.encode(
31+
message=render_context.last_error_message,
32+
).to_payload(),
33+
)

render_machine/code_renderer.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ def run(self):
5959
previous_state = deepcopy(self.render_context.state)
6060
self.render_context.script_execution_history.should_update_script_outputs = False
6161
# Reset error message at start of each iteration to prevent stale data
62-
self.render_context.last_error_message = None
6362

6463
outcome, previous_action_payload = self.action_map[self.render_context.state].execute(
6564
self.render_context, previous_action_payload

render_machine/render_context.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -443,6 +443,7 @@ def start_fixing_conformance_tests(self):
443443
self.conformance_tests_running_context.conformance_tests_render_attempts
444444
>= MAX_CONFORMANCE_TEST_RERENDER_ATTEMPTS
445445
):
446+
# TODO: Change the below error message
446447
error_msg = f"We've already tried to fix the issue by recreating the conformance tests but tests still fail. Please fix the issues manually. FRID: {self.frid_context.frid}, Render ID: {self.run_state.render_id}"
447448
self.dispatch_error(error_msg)
448449
else:

0 commit comments

Comments
 (0)