Fix error propagation in TUI

Author: Tjaz Erzen

plain2code.py

@@ -20,6 +20,7 @@
 from plain2code_exceptions import (
     ConflictingRequirements,
     CreditBalanceTooLow,
+    InternalClientError,
     InternalServerError,
     InvalidAPIKey,
     InvalidFridArgument,
@@ -30,7 +31,6 @@
     NetworkConnectionError,
     OutdatedClientVersion,
     PlainSyntaxError,
-    UnexpectedState,
 )
 from plain2code_logger import (
     CrashLogHandler,
@@ -295,7 +295,7 @@ def main():  # noqa: C901
         console.error(f"Invalid API key: {str(e)}\n")
     except OutdatedClientVersion as e:
         console.error(f"Outdated client version: {str(e)}\n")
-    except (InternalServerError, UnexpectedState):
+    except (InternalServerError, InternalClientError):
         exc_info = sys.exc_info()
         console.error(
             f"Internal server error.\n\nPlease report the error to support@codeplain.ai with the attached {args.log_file_name} file."

plain2code_exceptions.py

@@ -25,7 +25,7 @@ class PlainSyntaxError(Exception):
     pass
 
 
-class UnexpectedState(Exception):
+class InternalClientError(Exception):
     pass
 
 

render_machine/actions/analyze_specification_ambiguity.py

@@ -4,6 +4,7 @@
 import git_utils
 import plain_spec
 from plain2code_console import console
+from plain2code_exceptions import InternalClientError
 from plain2code_utils import AMBIGUITY_CAUSES
 from render_machine.actions.base_action import BaseAction
 from render_machine.render_context import RenderContext
@@ -17,7 +18,7 @@ def execute(self, render_context: RenderContext, _previous_action_payload: Any |
             render_context.build_folder, render_context.frid_context.frid
         )
         if fixed_implementation_code_diff is None:
-            raise Exception(
+            raise InternalClientError(
                 "Fixes to the implementation code found during conformance testing are not committed to git."
             )
         previous_frid = plain_spec.get_previous_frid(render_context.plain_source_tree, render_context.frid_context.frid)

render_machine/actions/fix_conformance_test.py

@@ -5,7 +5,7 @@
 import plain_spec
 from memory_management import MemoryManager
 from plain2code_console import console
-from plain2code_exceptions import UnexpectedState
+from plain2code_exceptions import InternalClientError
 from render_machine.actions.base_action import BaseAction
 from render_machine.implementation_code_helpers import ImplementationCodeHelpers
 from render_machine.render_context import RenderContext
@@ -21,7 +21,7 @@ def execute(self, render_context: RenderContext, previous_action_payload: Any |
         )
 
         if not previous_action_payload.get("previous_conformance_tests_issue"):
-            raise UnexpectedState("Previous action payload does not contain previous conformance tests issue.")
+            raise InternalClientError("Previous action payload does not contain previous conformance tests issue.")
         previous_conformance_tests_issue = previous_action_payload["previous_conformance_tests_issue"]
 
         render_context.conformance_tests_running_context.previous_conformance_tests_issue_old = (

render_machine/actions/fix_unit_tests.py

@@ -3,7 +3,7 @@
 import file_utils
 import render_machine.render_utils as render_utils
 from plain2code_console import console
-from plain2code_exceptions import UnexpectedState
+from plain2code_exceptions import InternalClientError
 from render_machine.actions.base_action import BaseAction
 from render_machine.implementation_code_helpers import ImplementationCodeHelpers
 from render_machine.render_context import RenderContext
@@ -16,7 +16,7 @@ class FixUnitTests(BaseAction):
 
     def execute(self, render_context: RenderContext, previous_action_payload: Any | None):
         if not previous_action_payload.get("previous_unittests_issue"):
-            raise UnexpectedState("Previous action payload does not contain previous unit tests issue.")
+            raise InternalClientError("Previous action payload does not contain previous unit tests issue.")
         previous_unittests_issue = previous_action_payload["previous_unittests_issue"]
 
         if previous_unittests_issue and len(previous_unittests_issue) > MAX_ISSUE_LENGTH:

render_machine/conformance_tests.py

@@ -3,6 +3,7 @@
 
 import file_utils
 from plain2code_console import console
+from plain2code_exceptions import InternalClientError
 from plain_modules import PlainModule
 
 CONFORMANCE_TESTS_DEFINITION_FILE_NAME = "conformance_tests.json"
@@ -69,7 +70,7 @@ def get_source_conformance_test_folder_name(
     ) -> tuple[str, str]:
         original_prefix = self.get_module_conformance_tests_folder(current_testing_module_name)
         if not original_conformance_test_folder_name.startswith(original_prefix):
-            raise Exception(
+            raise InternalClientError(
                 f"Unexpected conformance test folder name prefix {original_prefix} for {original_conformance_test_folder_name}!"
             )
 

tui/plain2code_tui.py

@@ -19,7 +19,6 @@
     RenderModuleStarted,
     RenderStateUpdated,
 )
-from plain2code_exceptions import InternalServerError, NetworkConnectionError
 from render_machine.states import States
 from tui.widget_helpers import log_to_widget
 
@@ -138,15 +137,7 @@ def on_worker_state_changed(self, event: Worker.StateChanged) -> None:
             # Extract the original exception from WorkerFailed wrapper
             error = event.worker.error
             original_error = error.__cause__ if isinstance(error, WorkerFailed) and error.__cause__ else error
-
-            # Connection-related errors are propagated as-is to show helpful error messages
-            # All other errors are wrapped in InternalServerError for consistent handling
-            if isinstance(original_error, NetworkConnectionError):
-                self.exit(result=original_error)
-            else:
-                internal_error = InternalServerError(str(original_error))
-                internal_error.__cause__ = original_error
-                self.exit(result=internal_error)
+            self.exit(result=original_error)
 
     def _handle_exception(self, error: Exception) -> None:
         """Override Textual's exception handler to suppress console tracebacks for worker errors.