move code from context to action

Author: NejcS

render_machine/actions/refactor_code.py

@@ -7,11 +7,26 @@
 from render_machine.render_context import RenderContext
 
 
+MAX_REFACTORING_ITERATIONS = 5
+
+
 class RefactorCode(BaseAction):
     SUCCESSFUL_OUTCOME = "refactoring_successful"
     NO_FILES_REFACTORED_OUTCOME = "no_files_refactored"
+    ITERATION_LIMIT_EXCEEDED_OUTCOME = "refactoring_iteration_limit_exceeded"
 
     def execute(self, render_context: RenderContext, _previous_action_payload: Any | None):
+        if render_context.frid_context.refactoring_iteration == 0:
+            console.info("Refactoring the generated code...")
+
+        render_context.frid_context.refactoring_iteration += 1
+
+        if render_context.frid_context.refactoring_iteration >= MAX_REFACTORING_ITERATIONS:
+            console.info(
+                f"Refactoring iterations limit of {MAX_REFACTORING_ITERATIONS} reached for functionality {render_context.frid_context.frid}."
+            )
+            return self.ITERATION_LIMIT_EXCEEDED_OUTCOME, None
+
         existing_files, existing_files_content = ImplementationCodeHelpers.fetch_existing_files(
             render_context.build_folder
         )

render_machine/render_context.py

@@ -23,7 +23,6 @@
 )
 
 MAX_UNITTEST_FIX_ATTEMPTS = 20
-MAX_REFACTORING_ITERATIONS = 5
 MAX_FUNCTIONAL_REQUIREMENT_RENDER_ATTEMPTS_FAILED_UNIT_DURING_CONFORMANCE_TESTS = 2
 
 
@@ -292,19 +291,6 @@ def _on_unit_test_limit_exceeded_in_refactoring(self):
         git_utils.revert_changes(self.build_folder)
         self.machine.dispatch(triggers.START_NEW_REFACTORING_ITERATION)
 
-    def start_refactoring_code(self):
-
-        if self.frid_context.refactoring_iteration == 0:
-            console.info("Refactoring the generated code...")
-
-        self.frid_context.refactoring_iteration += 1
-
-        if self.frid_context.refactoring_iteration >= MAX_REFACTORING_ITERATIONS:
-            console.info(
-                f"Refactoring iterations limit of {MAX_REFACTORING_ITERATIONS} reached for functionality {self.frid_context.frid}."
-            )
-            self.machine.dispatch(triggers.PROCEED_FRID_PROCESSING)
-
     def start_conformance_tests_processing(self):
         console.info("Implementing conformance tests...")
         current_frid_specifications, _ = plain_spec.get_specifications_for_frid(

render_machine/state_machine_config.py

@@ -80,6 +80,7 @@ def get_action_result_triggers_map(self) -> Dict[str, str]:
             FixUnitTests.SUCCESSFUL_OUTCOME: triggers.MARK_UNIT_TESTS_READY,
             RefactorCode.SUCCESSFUL_OUTCOME: triggers.REFACTOR_CODE,
             RefactorCode.NO_FILES_REFACTORED_OUTCOME: triggers.PROCEED_FRID_PROCESSING,
+            RefactorCode.ITERATION_LIMIT_EXCEEDED_OUTCOME: triggers.PROCEED_FRID_PROCESSING,
             CommitImplementationCodeChanges.SUCCESSFUL_OUTCOME: triggers.PROCEED_FRID_PROCESSING,
             FinishFunctionalRequirement.SUCCESSFUL_OUTCOME: triggers.PROCEED_FRID_PROCESSING,
             CreateDist.SUCCESSFUL_OUTCOME: triggers.FINISH_RENDER,
@@ -160,7 +161,6 @@ def get_states(self, render_context: RenderContext) -> List[Any]:
         refactoring_code_states = {
             "name": States.REFACTORING_CODE.value,
             "initial": States.READY_FOR_REFACTORING.value,
-            "on_enter": render_context.start_refactoring_code,
             "children": [
                 States.READY_FOR_REFACTORING.value,
                 self.get_processing_unit_tests_states(