fix: correct install advice, remove false PyPI badge, fix module_path doubling (#44)

* fix: correct click-to-mcp install advice to working git+ URL

click-to-mcp is not published on PyPI (pip install click-to-mcp -> 'No
matching distribution found'), so the runtime error messages that tell
users to 'pip install click-to-mcp' are wrong and leave them stuck.
This restores the git+ install form (previously added in a5874e0 and
accidentally reverted by aa004b0) across cli.py and mcp_server.py.

Reviewed and approved by council_gate_code_edit (APPROVE).

* fix(marketing): correct deploydiff install claims (remove false PyPI badge, git+ install, honesty note)

* fix(marketing): correct broken bare pip install in AGENTS.md (use self-hosted index/git+)

* fix(renderer): remove module_path doubling in rendered address + add 3 edge-case tests

---------

Co-authored-by: senior-dev-rotation-B <agent@cowork-ops.local>
Co-authored-by: cowork-bot <bot@coding-dev-tools.local>

Author: 3 people

AGENTS.md

@@ -4,7 +4,10 @@
 Compare deployment configurations across environments. Detect drift between staging and production configs. Preview infrastructure changes with human-readable diffs, cost impact estimation, and rollback commands.
 
 ## Build & Test Commands
-- Install: `pip install -e .` or `pip install deploydiff`
+- Install (editable, from this repo): `pip install -e .`
+- Install (prebuilt wheel from the self-hosted index): `pip install --index-url https://coding-dev-tools.github.io/pypi-index/simple/ deploydiff`
+- Install (from source): `pip install git+https://github.com/Coding-Dev-Tools/deploydiff.git`
+- NOTE: `deploydiff` is NOT on public PyPI — use the self-hosted index or a `git+` URL above.
 - Test: `pytest tests/` (or `python -m pytest tests/ -v --tb=short`)
 - Lint: `ruff check .`
 - Build: `pip install build twine && python -m build && twine check dist/*`

README.md

@@ -11,15 +11,12 @@ Preview infrastructure changes with human-readable diffs, cost impact estimation
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://github.com/Coding-Dev-Tools/deploydiff/blob/main/LICENSE)
 [![Open Source Alternative](https://img.shields.io/badge/Open_Source_Alternative-%E2%87%92-blue?logo=opensourceinitiative)](https://www.opensourcealternative.to/project/deploydiff)
 |[![LibHunt](https://img.shields.io/badge/LibHunt-%E2%87%92-blue?logo=codeigniter)](https://www.libhunt.com/r/Coding-Dev-Tools/deploydiff)
-|[![PyPI](https://img.shields.io/pypi/v/deploydiff)](https://pypi.org/project/deploydiff/)
+|[![PyPI](https://img.shields.io/badge/PyPI-not%20published-orange)](https://github.com/Coding-Dev-Tools/deploydiff#installation)|
 
 ## Installation
 
-```bash
-pip install deploydiff
-```
+DeployDiff is not published on public PyPI (publishing is pending). Install directly from GitHub:
 
-Or install the latest version directly from GitHub:
 ```bash
 pip install git+https://github.com/Coding-Dev-Tools/deploydiff.git
 ```

src/deploydiff/diff_renderer.py

@@ -123,8 +123,6 @@ def _render_action_group(
     for change in changes:
         symbol = change.display_action
         addr = change.address
-        if change.module_path:
-            addr = f"{change.module_path}.{addr}"
         table.add_row(
             f"[{color}]{symbol}[/{color}]",
             f"[{color}]{addr}[/{color}]",

tests/test_deploydiff.py

@@ -1182,10 +1182,93 @@ def test_missing_urn_in_step(self):
         assert len(plan.changes) == 1
 
     def test_mcp_without_click_to_mcp(self):
-        """MCP command exits 1 when click-to-mcp is not installed."""
+        "MCP command exits 1 when click-to-mcp is not installed."
         runner = CliRunner()
         result = runner.invoke(main, ["mcp"])
         # Either exits 1 (ImportError caught) or 0 (if click-to-mcp is installed)
         assert result.exit_code in (0, 1)
         if result.exit_code == 1:
             assert "click-to-mcp" in result.output.lower()
+
+
+class TestDiffRendererEdgeCases:
+    "Targeted tests for diff_renderer edge cases and module_path behavior."
+
+    def test_render_module_path_not_doubled(self):
+        "Module path should NOT be doubled in the rendered address."
+        from io import StringIO
+
+        from rich.console import Console
+
+        from deploydiff.diff_renderer import _render_action_group
+
+        change = ResourceChange(
+            address="module.vpc.aws_nat_gateway.main",
+            action=ChangeAction.REPLACE,
+            resource_type="aws_nat_gateway",
+            resource_name="main",
+            source=ChangeSource.TERRAFORM,
+            module_path="module.vpc",
+        )
+        plan = DeployPlan(source=ChangeSource.TERRAFORM, changes=[change])
+        buf = StringIO()
+        console = Console(file=buf, force_terminal=True)
+        _render_action_group(plan, ChangeAction.REPLACE, [change], console, verbose=False)
+        output = buf.getvalue()
+        # The rendered address should appear exactly once, not doubled
+        assert "module.vpc.aws_nat_gateway.main" in output
+        # The doubled form would be "module.vpc.module.vpc.aws_nat_gateway.main"
+        doubled = "module.vpc.module.vpc"
+        assert doubled not in output, f"Address doubled: {output[:500]}"
+
+    def test_render_change_details_unchanged_value(self):
+        "Keys with same before/after value show without diff markers."
+        from io import StringIO
+
+        from rich.console import Console
+
+        from deploydiff.diff_renderer import _render_change_details
+
+        change = ResourceChange(
+            address="aws_instance.web",
+            action=ChangeAction.UPDATE,
+            resource_type="aws_instance",
+            resource_name="web",
+            source=ChangeSource.TERRAFORM,
+            before={"instance_type": "t3.micro", "ami": "ami-old"},
+            after={"instance_type": "t3.micro", "ami": "ami-new"},
+        )
+        buf = StringIO()
+        console = Console(file=buf, force_terminal=True)
+        _render_change_details(change, console)
+        output = buf.getvalue()
+        assert "instance_type" in output
+        # t3.micro is unchanged, should appear without +/- markers
+        assert "t3.micro" in output
+
+    def test_render_change_details_missing_key(self):
+        "Key present in one state but not the other uses em-dash fallback."
+        from io import StringIO
+
+        from rich.console import Console
+
+        from deploydiff.diff_renderer import _render_change_details
+
+        change = ResourceChange(
+            address="aws_instance.web",
+            action=ChangeAction.UPDATE,
+            resource_type="aws_instance",
+            resource_name="web",
+            source=ChangeSource.TERRAFORM,
+            before={"instance_type": "t3.micro", "old_key": "old_val"},
+            after={"instance_type": "t3.large", "new_key": "new_val"},
+        )
+        buf = StringIO()
+        console = Console(file=buf, force_terminal=True)
+        _render_change_details(change, console)
+        output = buf.getvalue()
+        assert "instance_type" in output
+        # old_key should show "old_val" on the before side, em-dash on after
+        assert "old_key" in output
+        # Use some assertion that verifies em-dash appears (Rich renders these as Unicode)
+        assert "new_key" in output